Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <0000000000004fe2be05724ac084@google.com> <c8ffd001-8c67-19b9-7223-34ca8d436db2@gmail.com>
 <20180731134014.GA32114@bistromath.localdomain>
In-Reply-To: <20180731134014.GA32114@bistromath.localdomain>
From:   Cong Wang <xiyou.wangcong@gmail.com>
Date:   Tue, 31 Jul 2018 16:03:13 -0700
Message-ID: <CAM_iQpURKOMAaPfs9v7FzhqqQPzj71sQD2LS0eU8cuqTML-YoA@mail.gmail.com>
Subject: Re: KASAN: use-after-free Read in rtnetlink_put_metrics
To:     Sabrina Dubroca <sd@queasysnail.net>
Cc:     Eric Dumazet <eric.dumazet@gmail.com>,
        syzbot+41f9c04b50ef70c66947@syzkaller.appspotmail.com,
        christian.brauner@ubuntu.com, David Miller <davem@davemloft.net>,
        David Ahern <dsahern@gmail.com>,
        Florian Westphal <fw@strlen.de>, Jiri Benc <jbenc@redhat.com>,
        Kirill Tkhai <ktkhai@virtuozzo.com>,
        LKML <linux-kernel@vger.kernel.org>,
        lucien xin <lucien.xin@gmail.com>,
        Linux Kernel Network Developers <netdev@vger.kernel.org>,
        syzkaller-bugs@googlegroups.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jul 31, 2018 at 6:41 AM Sabrina Dubroca <sd@queasysnail.net> wrote:
>
> 2018-07-31, 05:41:56 -0700, Eric Dumazet wrote:
> >
> >
> > On 07/31/2018 05:31 AM, syzbot wrote:
> > > Hello,
> > >
> > > syzbot found the following crash on:
> > >
> > > HEAD commit:    61f4b23769f0 netlink: Don't shift with UB on nlk->ngroups
> > > git tree:       net
> > > console output: https://syzkaller.appspot.com/x/log.txt?x=14a9de58400000
> > > kernel config:  https://syzkaller.appspot.com/x/.config?x=ffb4428fdc82f93b
> > > dashboard link: https://syzkaller.appspot.com/bug?extid=41f9c04b50ef70c66947
> > > compiler:       gcc (GCC) 8.0.1 20180413 (experimental)
> > >
> > > Unfortunately, I don't have any reproducer for this crash yet.
> [...]
>
> > Probably also caused by :
> >
> >
> > commit df18b50448fab1dff093731dfd0e25e77e1afcd1
> > Author: Sabrina Dubroca <sd@queasysnail.net>
> > Date:   Mon Jul 30 16:23:10 2018 +0200
> >
> >     net/ipv6: fix metrics leak
>
> Yeah, I'm looking into both those reports :/

Looks like this commit is completely unnecessary,
fib6_drop_pcpu_from() calls fib6_info_release()
which calls fib6_info_destroy_rcu(), so this metrics
will be released twice...