Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp436846imm; Tue, 31 Jul 2018 22:27:23 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfHe8iWsSQ3R+o6VD7VaB+YKptI0y1vZ5vgKUDhiSwDED9WrLkeb/nHIrtemHWNjFTwVRmu X-Received: by 2002:a63:ea0c:: with SMTP id c12-v6mr13974621pgi.158.1533101243090; Tue, 31 Jul 2018 22:27:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533101243; cv=none; d=google.com; s=arc-20160816; b=qoBUune0dfG6t34AJxpgh4SYC90/Rj+d6g+NFhNPpzR2McHGUefp4qkc/aXk++J7Rt s0IJElp3XpIorYRdBk5o54AocxsgZtX/IIx+29VTC0N8qQbQOUUbWIVN0lePbwc5bq8g e8JdbjJzOAhkTOpwCSEy0eJWoIZiDbzDwE+kYnSGJ39dfTQDuIfg2Oas8hTLJtpWlYfZ TcVtrIT2FS3P2f+u1ppfSn/KmqE88HA9W9x3mkToQRMJOPzAkLSYTsykMCNkLpLXMuw+ n/XbYh0FNSWS2UqV346L1h3xzbE00jq+iikIo6lBBTsNmak2QzG+xlbdBpLkVOY4MqKl zvpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:subject:cc:from:to :in-reply-to:arc-authentication-results; bh=KnhT0QW+79BVxT7m5P4rPGFeaPqri543TrutRj+66Fk=; b=EmhKhRH6XvAVDuxSTsLpRPEDHi8+tO+xX2NFt4rUn79VIKonT4tp/s8MAd3rO0nbbX kJUxjdwigRW+Hv8u8hH0k4bg1MhplyEBVb0g/mniZQBT5Di5Q8aroLrAtqDAsp5ZRPgE tn9h1ciI1aF6lvv91Zi6J4ZlmPGEciJTBbFnIDkr7LJNjjIT68CrorNWIOdcD9844cD+ 9qnA+yjUWvCx2lHAQBD3R0RbNcuyxym99FmInpBPWeH8tcZIBOc++HN6R/Ann0uHa8gf rGxpWJN4Xa6UJ+qKIO5l9Qq3qSPr2Dqr+3B3i072RN3+1KjwCf9T5vc2VPQP7LP5nYB6 B81A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 67-v6si17184420pfc.21.2018.07.31.22.27.08; Tue, 31 Jul 2018 22:27:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733102AbeHAHHq (ORCPT + 99 others); Wed, 1 Aug 2018 03:07:46 -0400 Received: from ozlabs.org ([203.11.71.1]:53855 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733048AbeHAHHq (ORCPT ); Wed, 1 Aug 2018 03:07:46 -0400 Received: by ozlabs.org (Postfix, from userid 1034) id 41gMDG3RdFz9s3q; Wed, 1 Aug 2018 15:23:58 +1000 (AEST) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 73f4447d43484224d7abfba0d9468de4982ef889 In-Reply-To: <720e9899186bed184fb9b5cce070e2dc519f9665.1530519301.git.fthain@telegraphics.com.au> To: Finn Thain , Benjamin Herrenschmidt From: Michael Ellerman Cc: Michael Schmitz , linux-m68k@lists.linux-m68k.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [v4,01/11] macintosh/via-pmu: Fix section mismatch warning Message-Id: <41gMDG3RdFz9s3q@ozlabs.org> Date: Wed, 1 Aug 2018 15:23:58 +1000 (AEST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2018-07-02 at 08:21:18 UTC, Finn Thain wrote: > The pmu_init() function has the __init qualifier, but the ops struct > that holds a pointer to it does not. This causes a build warning. > The driver works fine because the pointer is only dereferenced early. > > The function is so small that there's negligible benefit from using > the __init qualifier. Remove it to fix the warning, consistent with > the other ADB drivers. > > Tested-by: Stan Johnson > Signed-off-by: Finn Thain > Reviewed-by: Geert Uytterhoeven Series applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/73f4447d43484224d7abfba0d9468d cheers