Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp473217imm; Tue, 31 Jul 2018 23:16:23 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcL2Y6G+Deftiw219cBc3ErJU3mZuHraNRA0eHMxxrC+azTJZagI1sAis/m2oyoQnSWp8ow X-Received: by 2002:a65:6699:: with SMTP id b25-v6mr23481906pgw.426.1533104183206; Tue, 31 Jul 2018 23:16:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533104183; cv=none; d=google.com; s=arc-20160816; b=YCL5VMPJ459E8Pw2WgRVrwabUxMwwXJ0f8lPlZ/z4l3tYUAOtDW4TbpFjmavHhUOJQ iQIPtvo2Pj4xLcu1e2iVlNZGOuQq4LZqmHIkNl47buakCXWRxHMLJX007oTXVcjFwJK7 dWVZrAYTLWc80nFrsvpaQDTSIWyDjGpGkOG80wG/7Q7gEahYts2e17bW9KhswQq7RM+P j90CKHoklaO+gcATVzrKOUyHB0adfI9d6yEsDtE2ZcrCiEVZ5Abzztjsv/qrzNgtMCM+ fe0zfCHs/XlDwLCmx6zyQtu9DP7pneCBWKTx6WmeGfyJa/ypiEA1nlIoSV94NzkxFSMX XO4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=UUVbcO95REXMlMMZsw5AQ4d//86tDf9ZVPLq/FunlaQ=; b=qR8WFx9brg7lhnpEVCwZrIxlgWdxm6fk7r/Vr9Og9NJixTdjfWOCtDktpohyHsB6Yi FEn0oAchpFfFpk5HavVeuGpRG7Rv5gIb2aaj4+oV6jQhhgcLHf5Vh5QK/6CTKdk7tbGV uHZvc+tjkvlILicvlVOWO1UIy9Svq1kc+Qn8OuVLP81XOP+L4SkyKHjt421oJt2zEOWx zMKu8FGe9wv2QgoQigX1EnV96c4bvIhID4rysQSh58NR2veVyTCknQ9ZIQcfe5pLxno5 qqqacfLyw6JEedBfqb9SgUzMB20mzKbgKrQdTaOKk5wN16vbcDOrU4fq7rgkZQbUAvjp G5tg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=qWhDpFdw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z137-v6si15390169pgz.144.2018.07.31.23.16.08; Tue, 31 Jul 2018 23:16:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=qWhDpFdw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733301AbeHAH7Q (ORCPT + 99 others); Wed, 1 Aug 2018 03:59:16 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:42494 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733098AbeHAH7Q (ORCPT ); Wed, 1 Aug 2018 03:59:16 -0400 Received: by mail-pf1-f195.google.com with SMTP id l9-v6so7295680pff.9; Tue, 31 Jul 2018 23:15:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=UUVbcO95REXMlMMZsw5AQ4d//86tDf9ZVPLq/FunlaQ=; b=qWhDpFdwRd18qpkX1qjIdeIzhWLvDOJ9sRWlE6MEUMcj+T6IZ9O/hutDNvBjjzDkmc d/WVb6AY1rFlH+jHwGPfer7/xJf91GFrwOiQOCOTd5VeVyeW0ZzWOTQ8cLw7E0RSgPoO TPwtHekVy7igHh4heQyvNk3wWYsUviIlpzFzayRgnzrh9QokXp5KQJTl2PR8spLvcHMu 4ZXKTtGbKg/WQjAF6pCHGASvShc5CPGVLeX6NxPGBin0HzRujk1R9sAc4hZs76cH13tC 6Y4gGlzn7lPmFjlvpYj8+XwU+jCKSBuhN1s9WD2tFI0/vAu0Y7veu8U8kkuahEU0UirV FOZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=UUVbcO95REXMlMMZsw5AQ4d//86tDf9ZVPLq/FunlaQ=; b=NizUhyUHgKZXc6pjKUCIKJimurA/lk07LXRljqgc3PPxeYXVNin2jBxtKsgo4qcIu7 S3LCWAeHEy3G3E+5IVcgqMTXVhFjE0hlKz6t+vauKHt4Zj0fcM9CNcbp9p4iLDSBfXuX naM5cVQ/xxpgZV3XUo+/FnooupLUou0ic4r6Jhjo4QtulYDeLx+uydj8/Hztuvcmgth3 QxsqS7UtXQy/tO6IaOIfzS2rpFoD4Jm6+J16vLSCOEGhRlnEa9ZgqOKavvSNMv2/wUkm xLh7euktAO+SFz4KmKghTWkxQZCxvmUMguF98LqzkWXPZhlftMbYeAZ3PPntjmF7E+TU W/Cw== X-Gm-Message-State: AOUpUlHzoAyvrhc7kfFqsfVTg1IDFi55HgT+LnYBbuZWRFJkUrg8J0/9 Bz5h9QYsc6hNHv5qa2DBlypfyjO+ X-Received: by 2002:a62:411a:: with SMTP id o26-v6mr15329703pfa.111.1533104118166; Tue, 31 Jul 2018 23:15:18 -0700 (PDT) Received: from localhost (c-24-4-233-174.hsd1.ca.comcast.net. [24.4.233.174]) by smtp.gmail.com with ESMTPSA id i20-v6sm26076598pfj.82.2018.07.31.23.15.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 31 Jul 2018 23:15:17 -0700 (PDT) Date: Tue, 31 Jul 2018 23:15:15 -0700 From: Richard Cochran To: "Y.b. Lu" Cc: "netdev@vger.kernel.org" , Madalin-cristian Bucur , Rob Herring , Shawn Guo , "David S . Miller" , "devicetree@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 3/3] ptp_qoriq: convert to use module parameters for initialization Message-ID: <20180801061515.krn52iaq2kqdi3wo@localhost> References: <20180730100154.27906-1-yangbo.lu@nxp.com> <20180730100154.27906-3-yangbo.lu@nxp.com> <20180730143043.qu66ttzwyjbw6si7@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 01, 2018 at 04:36:40AM +0000, Y.b. Lu wrote: > Could I add a function to calculate a set of default register values > to initialize ptp timer when dts method failed to get required > properties in driver? Yes, it would be ideal if the driver can pick correct values automatically. However, the frequency on the FIPER outputs can't be configured automatically, and we don't have an API for the user to choose this. > I think this will be useful. The ptp timer on new platforms (you may > see two dts patches in this patchset. Many platforms will be > affected.) will work without these dts properties. If user want > specific setting, they can set dts properties. Sure. Thanks, Richard