Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp571071imm; Wed, 1 Aug 2018 01:24:52 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfNJIdcB3TAivA05CaQlp9IRLTm7r7GL4mwSsx9y+Qc+S2+wqHe779ocJ7dN4fXLz1+fxzX X-Received: by 2002:a17:902:33c2:: with SMTP id b60-v6mr23778213plc.11.1533111892826; Wed, 01 Aug 2018 01:24:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533111892; cv=none; d=google.com; s=arc-20160816; b=l7Njug6KtK9uwH91IJ5BuNIAhTjKsDMrWIGmrTMdPSQPfneONePM2U0VWcPaNf9EGV ngcmFWnFwTUoS5HY+3CY8mSFO5+a0lfl/0CyX4WOOS2DmxYPCTYihCWA5B55vOxUWjvz 2E55+nvPl2ZbBiX89tkQVceV09/pRyaum3Vv9CIgs9V6Em3nDMRKURLI4UgTxTYepxQ+ XAo+Q6W06HTdrNV9CQtGKhVqGcW0TD9TmUZGkgUYgseZcHFgOSZKdrrHV3nb4Dl/fUPt RRao97UpIgRvNQKLVT5IV1bvAat6jBAQps6hftl2uIxorcP4r9D4p99WfDS3dGYpLc5s 6Htg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=+2ha2DqzjmWThBtVOxY8QkIqZM+flvhbzzcCq1k2uzU=; b=a0XrZ8gnzxZKGdhLw/KbsyUAfV2SqwYtqbhQ87fduJwOwv8tuQagR3cZT6vUwjTSBF XUDBrjmRyHjnWA1EIR/y/DBt0I8iq5c1HP3ur2isdx10Md4y57p3XF/Bw6XegSFV3L8H SlzwffOsrHvp7Kkfv3ziKPvnh8Z3gLz2gxk1EGHDIngxDQbzQwbEZ23iLMSCqcpkHO5C 6YIfDOepgkCf92ansvXZ/No7DQZvH1IVCohiY39P1c7qebr/lxUfak8rw8NK4mTPZOQ1 7Yp5ZpNc0mvYvP4qqZtP3fKJ0nr9J43wJZkHzqxS0GCfE4zg0fu0qCOxqmjqGNlrfHLI NF1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Oj4LLWeC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n38-v6si16628437pgb.536.2018.08.01.01.24.38; Wed, 01 Aug 2018 01:24:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Oj4LLWeC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388495AbeHAKIU (ORCPT + 99 others); Wed, 1 Aug 2018 06:08:20 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:50810 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387633AbeHAKIU (ORCPT ); Wed, 1 Aug 2018 06:08:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=+2ha2DqzjmWThBtVOxY8QkIqZM+flvhbzzcCq1k2uzU=; b=Oj4LLWeCFQXEWOqfnx4GQKEga +x1IJOCRoZML6h96S7omXtcQevB09ec84gkNEuwJgT63FmSwY4iUx4JI2YuR3xqmyphgYbq6yFmLp 3LNKWnoQHWih42mQcXUZdDVIWDEVaR2t1uR3ocXWRQ69Gx3iazHa4xIwPJYd1WF2xcba4nDfwJh71 VhgRTjEtVw2m+C1DjNV5i6Q7X1sWDjER0qgtuwHRjszp01xxWm9MJ0iJxIR3c2HonYDbI9NnhjdAq 212cnFCbBG+0o+Gel88vetBpn35dztb4TmKjgnv5D0ayqoyJsd9fqbFQE7bIdY1K4WPMqBDB2lds2 KvfHm6mhw==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1fkmPq-0000jE-NQ; Wed, 01 Aug 2018 08:23:30 +0000 Date: Wed, 1 Aug 2018 01:23:30 -0700 From: Christoph Hellwig To: Kees Cook Cc: Jens Axboe , Christoph Hellwig , "Martin K. Petersen" , "James E.J. Bottomley" , Tejun Heo , Borislav Petkov , "David S. Miller" , "Manoj N. Kumar" , "Matthew R. Ochs" , Uma Krishnan , "Nicholas A. Bellinger" , Thomas Gleixner , Philippe Ombredanne , Stephen Boyd , Cyrille Pitchen , Juergen Gross , Viresh Kumar , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Sagar Dharia , Randy Dunlap , Vinod Koul , David Kershner , linux-block@vger.kernel.org, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 6/9] ide-cd: Remove redundant sense buffer Message-ID: <20180801082330.GB26378@infradead.org> References: <20180731195155.46664-1-keescook@chromium.org> <20180731195155.46664-7-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180731195155.46664-7-keescook@chromium.org> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 31, 2018 at 12:51:51PM -0700, Kees Cook wrote: > This is already able to process the sense buffer, so remove the redundant > parsing during the failure path. This also fixes any possible stale values > since the prior code did not check the sense length. > > Signed-off-by: Kees Cook Looks good, Reviewed-by: Christoph Hellwig