Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp571909imm; Wed, 1 Aug 2018 01:26:01 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcSudHk4Hz7Iw5bu82zCCay3CMIr0sfmUtzsItFw4TDU4QC9PcCerKqXQYCNMozgRsdc/V5 X-Received: by 2002:a17:902:a989:: with SMTP id bh9-v6mr24036230plb.245.1533111961660; Wed, 01 Aug 2018 01:26:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533111961; cv=none; d=google.com; s=arc-20160816; b=o9RwuSGkDkJ0BUBONbykpHGqnRqIh1uoA+TB1Up5OlHpomI2jFJ9g41i1aOx9mltkn VB+PBEJBVO8HfVKSUMcswpl6NEmKfqmsgxruJZ6TdS3OTSwa5xVh9CG4FKfJQ/j2+BdA IKIxwM52Oypp2TA76H8gyKRVqk9H1yY0KUx1yjMmtqFzYh+C57HF7zQaw2yk5Ym3AToV dHyXUn0IqT5WmgWro27JQYCyrwcScX/qC1cCQPfsK6L2o22OXFjAfbGedxyAtRpIPp00 NYdvB8qh+wBJv+czojFNSHahhk8WXokCNN/SaWhsHeLmlX05mRyTPqk7BjvO1K81x/c/ m0xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=bMXYbd/2W2b99gk+kc4NjTlHj7CX0Zf1ocahnBfBlfs=; b=j9jwmJmcR3qaFLE1vKwFGkvXDq8Z6H5dIXghaktq//b5G9+IspCaCXwA4nwvG2D6n7 h4Is19EUKPGVUfQmwVIx6lwzHar7vQSESyseBWqKAKaFJdK8/vwZw6ASRjD2rTMJL4NX SkkC9tCsrnJkhd5PMBVNCUasvQk2sxUNjof23LWRtSj4v/h4Fg2hKTaLwpb+tr/YAQbu fo+38JClvbBlyQZy/kQrBg02Wr7PG19PcDzTxp3CJR0yBMZTfh/vXKCG4SkNNOR2fcCi 4Jarr65EnFNoP8Og633pqcwDCkNsjCHqBeqpuUpTmp3C9Fb9ZKnsn/sGbdiQef/A47s6 cGRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=IOrRhGPX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 79-v6si16055866pfs.40.2018.08.01.01.25.47; Wed, 01 Aug 2018 01:26:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=IOrRhGPX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388610AbeHAKI7 (ORCPT + 99 others); Wed, 1 Aug 2018 06:08:59 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:50856 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387721AbeHAKI7 (ORCPT ); Wed, 1 Aug 2018 06:08:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=bMXYbd/2W2b99gk+kc4NjTlHj7CX0Zf1ocahnBfBlfs=; b=IOrRhGPXS7d0WZKK/9u1NmwjW nX5Toi8oFOo1dH6aoyv5wB7ruhwLmmMnoQTHmRchbk+UghYLBMkjjGAjFz0vMqUjHHTIeSUGQzJCO Le53roGJmLIwvPKW0OS47iIUBWo+M7hiK8WBs3p+c1i4HRGZpkXuHqKZOKm6lKVGvgYea+0oOAg4C FfL98u0dbQvOifCObID4iHBeoEMCdJGeF7u2IuzozCsSHoySs+yT+UdxwifM2jGbUxWkpWY8BozD3 QZn7fgBgRvolS8eHnpVZ/ZrJXe0hJBq20HeqrSTHbWPdMv+Lc8nWunIJZj3XbvuTOKqXKZcKptGwd hnBVitvLA==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1fkmQR-0000lD-K4; Wed, 01 Aug 2018 08:24:07 +0000 Date: Wed, 1 Aug 2018 01:24:07 -0700 From: Christoph Hellwig To: Kees Cook Cc: Jens Axboe , Christoph Hellwig , "Martin K. Petersen" , "James E.J. Bottomley" , Tejun Heo , Borislav Petkov , "David S. Miller" , "Manoj N. Kumar" , "Matthew R. Ochs" , Uma Krishnan , "Nicholas A. Bellinger" , Thomas Gleixner , Philippe Ombredanne , Stephen Boyd , Cyrille Pitchen , Juergen Gross , Viresh Kumar , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Sagar Dharia , Randy Dunlap , Vinod Koul , David Kershner , linux-block@vger.kernel.org, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 7/9] cdrom: Use struct scsi_sense_hdr internally Message-ID: <20180801082407.GC26378@infradead.org> References: <20180731195155.46664-1-keescook@chromium.org> <20180731195155.46664-8-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180731195155.46664-8-keescook@chromium.org> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 31, 2018 at 12:51:52PM -0700, Kees Cook wrote: > This removes more casts of struct request_sense and uses the standard > struct scsi_sense_hdr instead. This also fixes any possible stale values > since the prior code did not check the sense length. > > Signed-off-by: Kees Cook Looks good, Reviewed-by: Christoph Hellwig