Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp572160imm; Wed, 1 Aug 2018 01:26:23 -0700 (PDT) X-Google-Smtp-Source: AAOMgpf/r4sdlBAyXeG+W9NDZtrJ8yGL6YDdgFG4XaRxA+gSRh3tYxjAZ/cmu4Oh4U/8/85+LVRJ X-Received: by 2002:a17:902:6b47:: with SMTP id g7-v6mr23931926plt.128.1533111983785; Wed, 01 Aug 2018 01:26:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533111983; cv=none; d=google.com; s=arc-20160816; b=L14HR30wPG1xLBVPWWJsZzEHDMQzcDfKRs4u8RyPWJrw9LFNMtghvOz0SBVAq89E+Z iYZlEeAG0wSvPNNcZq9ttGZjAPHzWi0wH1O/m2VYv70Vw4tHfT6owa6CBk2AodwwNTXU E5JWPB12IEL33m1PZAPm/A9ChbZfAtTESN+zS83NyL0rp+ujAULLDB+jxaZK6buIQ6YS nXjudRZ+ARnDEXWDDvjTJvRkkqTPoVSzuKFbL+oS5wWYoEWDFXgoI2WTqIYrNM+gI+1G 38fxtrfuhWEMzobKU9e3R8mkKk/B2Q5Oo2WuJ9CerBEKouWa4UtDyKt2WjHv8Ol4mh1Q BBnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=rnYMVv5RaPjWuXEAvUJS7VeNLbJ3P6eiDem+JGZZnTw=; b=Jf0We06cKorGFqMrrbDKoVDJMMFBgb6xWX2uN9b6dbksVCwwL8tly5ckqlKexAQRsz Kyafc6Abcr+IGVdfm4AilVcUlIzU/eccMAeZIkZm4Qf4He5IgQY0E+HMKM1iHUA4n6PM 8w6kCVmBBDRqq2ZCi0B5aiFkEaSdkkkhg85J5PhDrGrw2jLqkbA1W3ARaMNoNXqjW/DQ WrV14Zg7mGmNDX7HZJQT076I4oxFBcjXARo7F84nME1umgshFZs20y1PCdY7pD88MIDp A/mWRqVwYued1/OKU+MYTetRVX3Mo3HVhbq0qD85zy25NfN90T8+TA7PmZ5pMB1XSmp/ elMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=W57sdEJk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n1-v6si14562681pld.429.2018.08.01.01.26.09; Wed, 01 Aug 2018 01:26:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=W57sdEJk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388641AbeHAKJS (ORCPT + 99 others); Wed, 1 Aug 2018 06:09:18 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:50892 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387699AbeHAKJS (ORCPT ); Wed, 1 Aug 2018 06:09:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=rnYMVv5RaPjWuXEAvUJS7VeNLbJ3P6eiDem+JGZZnTw=; b=W57sdEJkIn7W/kKPt+mBqPG6j ExxQFOkJooicwSba8do5M7oRSGDSIuM5UCygdCujTxXLheXhqZ1J+vHHjpzPcibAKgDcFqZ6j7Fm4 t/2R82gybA7f0zg02cESEjGleCFcT7jUdwYEbEpTFj2s2r4PptqGITqrEb4Py/8waOpMMBWIVCHjw dmm1M2Oj+wtpYQyOAYRKNpLCNaWOE9DiatOqjIqkk+HbKT3nUdiwR3t25OQi0q+1q1RLjAc3RJpIV q8950df77PRXWw5rg3Z5cWE1V4YxvUjJAo67qaTeokWrWs3DSMot7OW0OE9NMvnOecVT5OAacRu0O 6a7zP0Fvw==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1fkmQn-0000mo-Me; Wed, 01 Aug 2018 08:24:29 +0000 Date: Wed, 1 Aug 2018 01:24:29 -0700 From: Christoph Hellwig To: Kees Cook Cc: Jens Axboe , Christoph Hellwig , "Martin K. Petersen" , "James E.J. Bottomley" , Tejun Heo , Borislav Petkov , "David S. Miller" , "Manoj N. Kumar" , "Matthew R. Ochs" , Uma Krishnan , "Nicholas A. Bellinger" , Thomas Gleixner , Philippe Ombredanne , Stephen Boyd , Cyrille Pitchen , Juergen Gross , Viresh Kumar , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Sagar Dharia , Randy Dunlap , Vinod Koul , David Kershner , linux-block@vger.kernel.org, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 8/9] libata-scsi: Move sense buffers onto stack Message-ID: <20180801082429.GD26378@infradead.org> References: <20180731195155.46664-1-keescook@chromium.org> <20180731195155.46664-9-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180731195155.46664-9-keescook@chromium.org> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 31, 2018 at 12:51:53PM -0700, Kees Cook wrote: > To support future compile-time sizeof() checks that will be able to > validate the length of sense buffers, this removes the only dynamically > allocated sense buffers in the tree by putting the 96 byte sense buffers > on the stack. > > Signed-off-by: Kees Cook Looks good, Reviewed-by: Christoph Hellwig