Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp630777imm; Wed, 1 Aug 2018 02:39:20 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfAjhzhiKz9pjOW6EusH3F4QyS2Buoi/yyVWvj6nAxuO+yhV7b+JOTNwzuAlgEvhZPDx737 X-Received: by 2002:a17:902:bd07:: with SMTP id p7-v6mr24373557pls.32.1533116360264; Wed, 01 Aug 2018 02:39:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533116360; cv=none; d=google.com; s=arc-20160816; b=P4TYYcphkaY3VgK0Cf+PvZ2yZWjYJMdaP41PiCwlHURRdaR2yrCrsa8yOAOvEPMx9W RjXvpJRacTL1PPpvNcE35fbl/nU40vO9jJTge3rz6AgEfFW8JcH88Mg4K2ojzqOiHTgb gtGMg0qXTTL5dyZbtcxGtDs1DbQWYxANMRVK/iBx0PSiUkl/5yaOvyjtwcxfhXWvNZ4q rjY45skXOLG1tojqUJVvsU1uOX5f5TbK4bLCquxIYJl31x0YwThZ5LbzWEvSpo6I2dTH doHzsd9Y1+FTBVoEjQFTNp002NwC96xxLdkCILnm4v46r1MS9PGjgq5wJ1W4x4FtMHMY eHTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:arc-authentication-results; bh=616QJtdSa9AFuzF16ky4uoFGHhCX5Df6CDL9vt1zITA=; b=dhiOZBA490wWq7kZoJXVc3SFZnQGnK+Ufx5e3QxlOERT/IWJ0JW4n504DsZOHNaAeK BjTcTxZWgNarygVpNJn3T+lsu0pRr9YZ4h37mKnSMG6VaMmpzyagaYT2YlsdnzTHsyQI Uk3a4qeHYK93uDPCRg7AeTQVLKPqhGRW5waE9wEyhTPIU1QLuuVKafgyVWPW6t6T4VJO KQzqkJ37/t0Mnv+NvXmrwaF+L24Kc+GNvtaqjNru4/RMvK41Aqjk3/v45I8dk3lNxuaW fVDbKG2YMLKI0kzuM8h5K/fus2WHHqHMkEWU0bNLFiF7pzp2agL++AGWUBp5PUEyGMak er1A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p64-v6si15726766pga.25.2018.08.01.02.39.03; Wed, 01 Aug 2018 02:39:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389221AbeHALWu (ORCPT + 99 others); Wed, 1 Aug 2018 07:22:50 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:32624 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388612AbeHALWt (ORCPT ); Wed, 1 Aug 2018 07:22:49 -0400 Received: from pps.filterd (m0046037.ppops.net [127.0.0.1]) by mx07-.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id w719TSGl009408; Wed, 1 Aug 2018 11:37:38 +0200 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 2kjnaddbdr-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 01 Aug 2018 11:37:38 +0200 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 3A86231; Wed, 1 Aug 2018 09:37:38 +0000 (GMT) Received: from Webmail-eu.st.com (Safex1hubcas22.st.com [10.75.90.92]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id B87E9296F; Wed, 1 Aug 2018 09:37:37 +0000 (GMT) Received: from SAFEX1HUBCAS24.st.com (10.75.90.95) by Safex1hubcas22.st.com (10.75.90.92) with Microsoft SMTP Server (TLS) id 14.3.361.1; Wed, 1 Aug 2018 11:37:37 +0200 Received: from lmecxl0923.lme.st.com (10.48.0.237) by webmail-ga.st.com (10.75.90.48) with Microsoft SMTP Server (TLS) id 14.3.361.1; Wed, 1 Aug 2018 11:37:37 +0200 From: Ludovic Barre To: Ulf Hansson , Rob Herring CC: Maxime Coquelin , Alexandre Torgue , Gerald Baeza , , , , , Ludovic Barre Subject: [PATCH 14/14] mmc: mmci: add validate_data callback Date: Wed, 1 Aug 2018 11:37:01 +0200 Message-ID: <1533116221-380-15-git-send-email-ludovic.Barre@st.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1533116221-380-1-git-send-email-ludovic.Barre@st.com> References: <1533116221-380-1-git-send-email-ludovic.Barre@st.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.48.0.237] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-08-01_03:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ludovic Barre This patch adds validate_data callback at mmci_host_ops to check specific constraints of variant. Signed-off-by: Ludovic Barre --- drivers/mmc/host/mmci.c | 39 +++++++++++++++++++++------------------ drivers/mmc/host/mmci.h | 1 + 2 files changed, 22 insertions(+), 18 deletions(-) diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c index d5ca93e..7ba2f61 100644 --- a/drivers/mmc/host/mmci.c +++ b/drivers/mmc/host/mmci.c @@ -234,24 +234,6 @@ static int mmci_card_busy(struct mmc_host *mmc) return busy; } -/* - * Validate mmc prerequisites - */ -static int mmci_validate_data(struct mmci_host *host, - struct mmc_data *data) -{ - if (!data) - return 0; - - if (!is_power_of_2(data->blksz)) { - dev_err(mmc_dev(host->mmc), - "unsupported block size (%d bytes)\n", data->blksz); - return -EINVAL; - } - - return 0; -} - static void mmci_reg_delay(struct mmci_host *host) { /* @@ -365,6 +347,27 @@ static void mmci_set_clkreg(struct mmci_host *host, unsigned int desired) mmci_write_clkreg(host, clk); } +/* + * Validate mmc prerequisites + */ +static int mmci_validate_data(struct mmci_host *host, + struct mmc_data *data) +{ + if (!data) + return 0; + + if (!is_power_of_2(data->blksz)) { + dev_err(mmc_dev(host->mmc), + "unsupported block size (%d bytes)\n", data->blksz); + return -EINVAL; + } + + if (host->ops && host->ops->validate_data) + return host->ops->validate_data(host, data); + + return 0; +} + int mmci_prepare_data(struct mmci_host *host, struct mmc_data *data, bool next) { int err; diff --git a/drivers/mmc/host/mmci.h b/drivers/mmc/host/mmci.h index 0a4811d..10b71bf 100644 --- a/drivers/mmc/host/mmci.h +++ b/drivers/mmc/host/mmci.h @@ -273,6 +273,7 @@ struct variant_data { /* mmci variant callbacks */ struct mmci_host_ops { + int (*validate_data)(struct mmci_host *host, struct mmc_data *data); int (*prepare_data)(struct mmci_host *host, struct mmc_data *data, bool next); void (*unprepare_data)(struct mmci_host *host, struct mmc_data *data, -- 2.7.4