Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp692793imm; Wed, 1 Aug 2018 03:50:00 -0700 (PDT) X-Google-Smtp-Source: AAOMgpf0Wq/UFCXH2DRrSDvRF7X/CPd7GnKRyUFytFVQYWi53F+IU+jtMrGGsoEFXqPdU9C9Nv9T X-Received: by 2002:a63:6188:: with SMTP id v130-v6mr24097580pgb.100.1533120600755; Wed, 01 Aug 2018 03:50:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533120600; cv=none; d=google.com; s=arc-20160816; b=ark2aZRo/uX3mgMyZ9hre6SDSc8L9ukNXjzQjXJfXCSZUKIWmZIVltcpy18zG0iexE dsKumX9RhsLuAG97g5Z/v361dEmeM6EUnyktKS+wSaYC1fTRzfrDZsmBubwDgIbZB3vi camCEmMKGsp3xUwRPPHxHDmFM40yK4OnJZT5VusbrbxLL0wZQ+icghA+EXFfhkVNH1Kx qppDh3W2IGPRtRgVBlwzIxjyb6B+l9r0wrPGZ3iXfXdJybuPVqGmMWdYAScYOzNLlmh6 fH+jJNODr0A3HPXUDK13y88V3NeyAAJo/svO8zeRlkJM7rBY4DabHIkjb0OefNZk7WIC ZztQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=9JSxoNc+Q0cii45s7gdGyuZ3JnoUFDqII/4w7pAsMhA=; b=w3f08H8ahwunIZ5C6szSmqUK9Rd5jpf5R4feB+faxnaPeIt00Faf1MC27jRsZwe/4Y fuGtoeJMMKhL8+NMARcAB1gNa3yhJxjyFIEXnEm0+puqEgpGmKF6aFSbi1+eXJTx7hug d3iF7ylXl2PHbQgqFWtjewGTHg4UA64RjAFQQjkjvCVsrRJK4na10UimBaJrEVqF1ZfX IG2C52dEAH/SYVWivCJE7gd//nGXqu5wbyyzLJwg/zgwKqg+CkJ9CHetuH2i9tkgX7ci bPLHnuYWHWctjjLAMzLrANLovBBHUTakdR0kMKplBskJosUGqpP/Y5Ixf/CxlJSS6vwo pBwQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l5-v6si15829657pls.13.2018.08.01.03.49.44; Wed, 01 Aug 2018 03:50:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388846AbeHAMdf (ORCPT + 99 others); Wed, 1 Aug 2018 08:33:35 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:39177 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387552AbeHAMdC (ORCPT ); Wed, 1 Aug 2018 08:33:02 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1fkofP-0006WD-UK; Wed, 01 Aug 2018 10:47:44 +0000 From: Colin King To: Jaroslav Kysela , Takashi Iwai , Jaya Kumar , Liam Girdwood , Mark Brown , Olivier Moysan , Arnaud Pouliquen , Maxime Coquelin , Alexandre Torgue , alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/9] ALSA: cs5535audio: remove redundant pointer 'dma' Date: Wed, 1 Aug 2018 11:47:35 +0100 Message-Id: <20180801104742.4328-3-colin.king@canonical.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180801104742.4328-1-colin.king@canonical.com> References: <20180801104742.4328-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King Pointer 'dma' is being assigned but is never used hence it is redundant and can be removed. Cleans up two clang warnings: warning: variable 'dma' set but not used [-Wunused-but-set-variable] Signed-off-by: Colin Ian King --- sound/pci/cs5535audio/cs5535audio.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/sound/pci/cs5535audio/cs5535audio.c b/sound/pci/cs5535audio/cs5535audio.c index de409cda50aa..4590086d9cd8 100644 --- a/sound/pci/cs5535audio/cs5535audio.c +++ b/sound/pci/cs5535audio/cs5535audio.c @@ -192,8 +192,6 @@ static void process_bm0_irq(struct cs5535audio *cs5535au) bm_stat = cs_readb(cs5535au, ACC_BM0_STATUS); spin_unlock(&cs5535au->reg_lock); if (bm_stat & EOP) { - struct cs5535audio_dma *dma; - dma = cs5535au->playback_substream->runtime->private_data; snd_pcm_period_elapsed(cs5535au->playback_substream); } else { dev_err(cs5535au->card->dev, @@ -208,11 +206,8 @@ static void process_bm1_irq(struct cs5535audio *cs5535au) spin_lock(&cs5535au->reg_lock); bm_stat = cs_readb(cs5535au, ACC_BM1_STATUS); spin_unlock(&cs5535au->reg_lock); - if (bm_stat & EOP) { - struct cs5535audio_dma *dma; - dma = cs5535au->capture_substream->runtime->private_data; + if (bm_stat & EOP) snd_pcm_period_elapsed(cs5535au->capture_substream); - } } static irqreturn_t snd_cs5535audio_interrupt(int irq, void *dev_id) -- 2.17.1