Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 01 Aug 2018 13:00:11 +0200
Message-ID: <s5hin4unyh0.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc:     "Colin King" <colin.king@canonical.com>,
        <alsa-devel@alsa-project.org>,
        "Jaya Kumar" <jayakumar.alsa@gmail.com>,
        "Liam Girdwood" <lgirdwood@gmail.com>,
        "Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
        "Mark Brown" <broonie@kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        "Jaroslav Kysela" <perex@perex.cz>,
        "Alexandre Torgue" <alexandre.torgue@st.com>,
        "Arnaud Pouliquen" <arnaud.pouliquen@st.com>,
        "Olivier Moysan" <olivier.moysan@st.com>,
        <kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 9/9] ALSA: intel_hdmi: remove redundant variable cfg_val
In-Reply-To: <20180801104742.4328-10-colin.king@canonical.com>
References: <20180801104742.4328-1-colin.king@canonical.com>
        <20180801104742.4328-10-colin.king@canonical.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/26
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 01 Aug 2018 12:47:42 +0200,
Colin King wrote:
> 
> From: Colin Ian King <colin.king@canonical.com>
> 
> Variable cfg_val is being assigned but is never used hence it is
> redundant and can be removed.
> 
> Cleans up clang warning:
> warning: variable 'cfg_val' set but not used [-Wunused-but-set-variable]
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  sound/x86/intel_hdmi_audio.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/sound/x86/intel_hdmi_audio.c b/sound/x86/intel_hdmi_audio.c
> index edc9f5a34eff..fa7dca5a68c8 100644
> --- a/sound/x86/intel_hdmi_audio.c
> +++ b/sound/x86/intel_hdmi_audio.c
> @@ -290,7 +290,6 @@ static void had_reset_audio(struct snd_intelhad *intelhaddata)
>  static int had_prog_status_reg(struct snd_pcm_substream *substream,
>  			struct snd_intelhad *intelhaddata)
>  {
> -	union aud_cfg cfg_val = {.regval = 0};
>  	union aud_ch_status_0 ch_stat0 = {.regval = 0};
>  	union aud_ch_status_1 ch_stat1 = {.regval = 0};
>  
> @@ -298,7 +297,6 @@ static int had_prog_status_reg(struct snd_pcm_substream *substream,
>  					  IEC958_AES0_NONAUDIO) >> 1;
>  	ch_stat0.regx.clk_acc = (intelhaddata->aes_bits &
>  					  IEC958_AES3_CON_CLOCK) >> 4;
> -	cfg_val.regx.val_bit = ch_stat0.regx.lpcm_id;

Actually this made me wonder what is the definition of val_bit.
It seems always 1 in the current code after the commit 964ca8083c02.
Pierre?


thanks,

Takashi