Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 1 Aug 2018 11:59:37 -0400
From:   Don Zickus <dzickus@redhat.com>
To:     Sinan Kaya <okaya@kernel.org>
Cc:     linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@kernel.org>,
        Philippe Ombredanne <pombredanne@nexb.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Colin Ian King <colin.king@canonical.com>,
        Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] watchdog: Reduce message verbosity
Message-ID: <20180801155937.hwsgqpa5n4q2dkfe@redhat.com>
References: <20180730190949.141996-1-okaya@kernel.org>
 <20180730192800.nqdhugzbxmin6e25@redhat.com>
 <4e5def8b-df29-0efb-7e35-e71070e94d91@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4e5def8b-df29-0efb-7e35-e71070e94d91@kernel.org>
User-Agent: NeoMutt/20180622
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jul 30, 2018 at 12:43:34PM -0700, Sinan Kaya wrote:
> Hi Don,
> 
> On 7/30/2018 12:28 PM, Don Zickus wrote:
> > > [    0.152492] NMI watchdog: Perf event create on CPU 0 failed with -2
> > > [    0.156002] NMI watchdog: Perf NMI watchdog permanently disabled
> > Hi Sinan,
> > 
> > Any reason why?  Usually when the 'perf event' fails, that indicates a
> > system problem.  And most folks don't boot with the 'debug' option.  This
> > means these unusual failures are hidden and become difficult to debug later
> > when it propagates.
> 
> Sorry, I should have been more clear. I'm only suppressing the first
> error message.
> 
> [    0.152492] NMI watchdog: Perf event create on CPU 0 failed with -2
> 
> Second message is still visible during boot. User knows that NMI watchdog is
> disabled.
> 
> [    0.156002] NMI watchdog: Perf NMI watchdog permanently disabled
> 
> Code is trying to probe the platform capabilities and is failing
> because of missing PMU in the system. If someone is interested in
> finding out why watchdog was disabled, they can turn on the debug
> message level.
> 
> > 
> > Or are you running the watchdog in a different configuration such that this
> > is a common nuisance that you are trying to suppress?
> 
> Yup, system doesn't support PMU.

Hi Sinan,

Oh, I see.  You are just trying to hide the always failing probe.  It seems
to make sense.

Acked-by: Don Zickus <dzickus@redhat.com>