Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 1 Aug 2018 09:10:11 -0700
From:   Tejun Heo <tj@kernel.org>
To:     Dennis Zhou <dennisszhou@gmail.com>
Cc:     Jens Axboe <axboe@kernel.dk>, Josef Bacik <jbacik@fb.com>,
        kernel-team@fb.com, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH v2] block: make iolatency avg_lat exponentially decay
Message-ID: <20180801161011.GS1206094@devbig004.ftw2.facebook.com>
References: <20180801002559.36261-1-dennisszhou@gmail.com>
 <20180801154958.GP1206094@devbig004.ftw2.facebook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180801154958.GP1206094@devbig004.ftw2.facebook.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Aug 01, 2018 at 08:49:58AM -0700, Tejun Heo wrote:
> Hello,
> 
> On Tue, Jul 31, 2018 at 05:25:59PM -0700, Dennis Zhou wrote:
> ...
> > +	/*
> > +	 * CALC_LOAD takes in a number stored in fixed point representation.
> > +	 * Because we are using this for IO time in ns, the values stored
> > +	 * are significantly larger than the FIXED_1 denominator (2048).
> > +	 * Therefore, rounding errors in the calculation are negligible and
> > +	 * can be ignored.
> > +	 */
> > +	exp_idx = min_t(int, BLKIOLATENCY_NR_EXP_FACTORS - 1,
> > +			iolat->cur_win_nsec / BLKIOLATENCY_EXP_BUCKET_SIZE);
> 
> Build bot is complaining about naked 64bit div.  Should use one of the
> div64*() helpers.
> 
> Looks good to me.  Once Johannes's concerns are addressed, please feel
> free to add

Ooh, one nitpick.  total_lat_avg is a bit of a misnomer now.  Maybe
rename to lat_avg?

Thanks.

-- 
tejun