Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1067609imm; Wed, 1 Aug 2018 09:39:59 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfmKs/GdtFvhXpu6OYsLjE+sHL30hMQc/aL553jPYlxPyia1lTNMJiTum9Hx/h/7YBzxYDF X-Received: by 2002:a62:225d:: with SMTP id i90-v6mr27248452pfi.246.1533141599094; Wed, 01 Aug 2018 09:39:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533141599; cv=none; d=google.com; s=arc-20160816; b=bYJAywk+gEi8M90Q8M2OsKlLI5b6VG5BqOBEXeqBAmSomTfC4ECsfKCwnh14En7sWx IK2YxCsKM7YZXQYiMIpLM/3Msog9ZRnLOTsZvT9ZA6P61kTn5kGbiKDFp4xA0RH91XIr P0wZJ0oK0OYAbVFI/MOZOioa6DvYUAHBVKMAAQi0RC1UC2017lzYXdHzh0XKiNBFoWBl TVbz01lsPTmG4u5mLpPFaE0I4vK6q22v1Bt19uboMeCV8qwVhMDHytZt2954su+T5IUC /spOnEogbAOdVBZwXZp04Q8+/f9hcALxcYzBC22YZKrqUEOP+Y3fwNLpZjd/Ct1KnyMf cbrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=mgGDKf6VUx6ZlBAS45Wg8ey3NTrp3YreIo07OyRy9F8=; b=h6i2uSqB84VpdA2mB/rc70wzSMXCDbLRFfLuGR9h2llOfl2HdDac2gy0JPH26f/Bi3 gsndIAfD5zLifxGelCu0sPCesfqQwbTOHX5nbzpcujN2y554VQtXA6u727ohCWFdz70v 5QWQB49qpMwqWnQqZwGRBxMn53isQlf780smMPdC0ZiqNYSlgqARG8zJfiYUgkmnBQJG OMZeG9gIm9n3siCy93x5FudfX7rYs+M8h381f08siOYue4IFwIfRDq2xnvggeM5y9baU 1S9BOX9xCMT43wj9SS9yKQEDFkymhgnVE0Eds0LUi4UydcstRg9eC672naWeDXYeiTAH L2xA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r138-v6si18791416pfc.202.2018.08.01.09.39.44; Wed, 01 Aug 2018 09:39:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403912AbeHASY6 (ORCPT + 99 others); Wed, 1 Aug 2018 14:24:58 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:48638 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389691AbeHASY6 (ORCPT ); Wed, 1 Aug 2018 14:24:58 -0400 Received: from localhost (c-24-20-22-31.hsd1.or.comcast.net [24.20.22.31]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 0C366100A3F96; Wed, 1 Aug 2018 09:38:25 -0700 (PDT) Date: Wed, 01 Aug 2018 09:38:24 -0700 (PDT) Message-Id: <20180801.093824.692154182807362672.davem@davemloft.net> To: gustavo@embeddedor.com Cc: tariqt@mellanox.com, saeedm@mellanox.com, leon@kernel.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net/mlx5e: Fix uninitialized variable From: David Miller In-Reply-To: <20180731142157.GA24066@embeddedor.com> References: <20180731142157.GA24066@embeddedor.com> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 01 Aug 2018 09:38:25 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Gustavo A. R. Silva" Date: Tue, 31 Jul 2018 09:21:57 -0500 > There is a potential execution path in which variable *err* is returned > without being properly initialized previously. > > Fix this by initializing variable *err* to 0. > > Addresses-Coverity-ID: 1472116 ("Uninitialized scalar variable") > Fixes: 0ec13877ce95 ("net/mlx5e: Gather all XDP pre-requisite checks in a single function") > Signed-off-by: Gustavo A. R. Silva Applied to net-next.