Subject: Re: [PATCH] ide-io.c, kernel 2.4.22 Fix for IO stats in
	/proc/partitions, was Re: sard/iostat disk I/O statistics/accounting for
	2.5.8-pre3
From: "Stephen C. Tweedie" <sct@redhat.com>
To: Chad Talbott <ctalbott@google.com>, ".A. Magallon" <jamagallon@able.es>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
       Stephen Tweedie <sct@redhat.com>, Alan Cox <alan@lxorguk.ukuu.org.uk>
In-Reply-To: <20030924092418.A28838@devserv.devel.redhat.com>
References: <20030924092418.A28838@devserv.devel.redhat.com>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Organization: 
Message-Id: <1064412912.21892.19.camel@sisko.scot.redhat.com>
Mime-Version: 1.0
Date: 24 Sep 2003 15:15:12 +0100
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1114
Lines: 31

Hi,

On Wed, 2003-09-24, Chad Talbott wrote:


> Here's the one that I compiled and tested. It makes /proc/partitions
> report correctly.

Looks OK, but I'd defer to an IDE expert on the question of whether this
is the best fix or not.

Basically, you need to pair accounting start points with accounting end
points.  This patch removes the end point from the IDE special-command
postprocessing, but only by manually replacing end_that_request_last()
with a variant which doesn't do accounting.

I'd really rather see a patch which accounted for the start of the
special command in the first place (via "req_new_io()" when the special
request is first queued), as I suspect that might be a more robust way
of doing things.  But as I said, it would take somebody more familiar
with the IDE code to know whether that's really going to be better or
not.

Cheers,
 Stephen

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/