Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1108858imm; Wed, 1 Aug 2018 10:19:15 -0700 (PDT) X-Google-Smtp-Source: AAOMgpc3indZWgRiI7yN4tLLS+nct69ffgp8v+c7+crEKPoIHVIzobixXE/4vcqwA4hUY/L2UkJl X-Received: by 2002:a62:15c8:: with SMTP id 191-v6mr27392355pfv.194.1533143955826; Wed, 01 Aug 2018 10:19:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533143955; cv=none; d=google.com; s=arc-20160816; b=WvhVSoB6qp6xUfFAT5/8hUI4ytpgIwkwUFCTcXvr/TC3QJePpkIQWQfUWBG4k70ACP QQE29mWUit1G0i5efA+njC2uWaRlWOjcpkJMAKpEHv5/mJDV3VnzkfWrlIIwL0emp9kA Kn8jE5O4FFkMp3Ks2CN1qoZEYQ+uPJ28IsmOSti/q+O6fmv0Sl6LZl11yZo5zKPuDtBP wDVhr+SJezfV40ZC+fXOy5MqbNsaaCsQNvJXvnACgGDkFeL9UkHs663HUk4psi6iAU5l b4Spi473+6uVonvI1zUFK+DGPIMDhsonybhy48CQCxO5o1PSbc+BJYuwXiT2XOtHCKhB Xfcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=Vmww2+n5EJCFwBi49X6BzG7xeJuD9FeljItv2tVJteg=; b=PCEf1txNRpkkEFu4RkGkwG95+di60zbU9339kcInEHzgRPcdaLLi8itsRqr7k2zOX4 2Okt4A4+K/5wuSTuZLzbQDZyOIlMQcdfWCNo+3FetZrJlRddDKvCj5OWjcOcNfA5hr0d XAXS6MMQ2KUEDsJmzET+imd7y3fErXqY8U+zZabLRN4uu6ecoW043xY1+CjrbmrCAIc6 9oobWS9lrnYhdwlQWtmL7UFcZElV8VvNxUbVQ9K7uyxDNiM1g+gpDTHqrbQyit+Mrccs 6gmQ3C5pHoz0xo7zsRITDZKOwfEvIpF1rdhO2IBVy/bZhyMQkQN3eL30m65ezj6P14HF pdhQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y23-v6si17116540pli.389.2018.08.01.10.19.01; Wed, 01 Aug 2018 10:19:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404687AbeHATEI (ORCPT + 99 others); Wed, 1 Aug 2018 15:04:08 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:46342 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404069AbeHATEH (ORCPT ); Wed, 1 Aug 2018 15:04:07 -0400 Received: from localhost (D57E6652.static.ziggozakelijk.nl [213.126.102.82]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 12460C9D; Wed, 1 Aug 2018 17:17:26 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tony Lindgren , Mark Brown , Sasha Levin Subject: [PATCH 4.14 114/246] spi: Add missing pm_runtime_put_noidle() after failed get Date: Wed, 1 Aug 2018 18:50:24 +0200 Message-Id: <20180801165017.167365266@linuxfoundation.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180801165011.700991984@linuxfoundation.org> References: <20180801165011.700991984@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Tony Lindgren [ Upstream commit 7e48e23a1f4a50f93ac1073f1326e0a73829b631 ] If pm_runtime_get_sync() fails we should call pm_runtime_put_noidle(). This is probably not a critical fix as we should only hit this when things are broken elsewhere. Signed-off-by: Tony Lindgren Signed-off-by: Mark Brown Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/spi/spi.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -1222,6 +1222,7 @@ static void __spi_pump_messages(struct s if (!was_busy && ctlr->auto_runtime_pm) { ret = pm_runtime_get_sync(ctlr->dev.parent); if (ret < 0) { + pm_runtime_put_noidle(ctlr->dev.parent); dev_err(&ctlr->dev, "Failed to power device: %d\n", ret); mutex_unlock(&ctlr->io_mutex);