Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261357AbTIXOzF (ORCPT ); Wed, 24 Sep 2003 10:55:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261362AbTIXOzF (ORCPT ); Wed, 24 Sep 2003 10:55:05 -0400 Received: from mail-03.iinet.net.au ([203.59.3.35]:8578 "HELO mail.iinet.net.au") by vger.kernel.org with SMTP id S261357AbTIXOzC (ORCPT ); Wed, 24 Sep 2003 10:55:02 -0400 Date: Wed, 24 Sep 2003 22:46:43 +0800 (WST) From: Ian Kent To: Arjan van de Ven cc: Kernel Mailing List , Maneesh Soni , autofs mailing list , Jeremy Fitzhardinge Subject: Re: [PATCH] autofs4 deadlock during expire - kernel 2.6 In-Reply-To: <20030924155720.C31236@devserv.devel.redhat.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1114 Lines: 35 On Wed, 24 Sep 2003, Arjan van de Ven wrote: > On Wed, Sep 24, 2003 at 09:38:16PM +0800, Ian Kent wrote: > > > interruptible_sleep_on ? > > > > > > > OK so maybe I should have suggestions instead of comments. > > instead of interruptible_sleep_on(), it looks like you really want > to use completions for this code.. > see kernel/workqueue.c for how those are used > I did try that but thinking again ... The actual expire really needs to be interrutible. I didn't like the idea that the additional waiters would be uninterruptible but perhaps I have no choice. Given that do you think that using an interruptible_sleep_on for the expire and a completion for the additional waiters could give an acceptable solution? -- ,-._|\ Ian Kent / \ Perth, Western Australia *_.--._/ E-mail: raven@themaw.net v Web: http://themaw.net/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/