Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1110707imm; Wed, 1 Aug 2018 10:21:05 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfwort2Ytz+n88hBFYnBlZWeORzPUh3pPsti6vG5ygRYi4VW5Ahx76t2oVy8B1TNptF88EC X-Received: by 2002:a63:c114:: with SMTP id w20-v6mr25199749pgf.234.1533144065860; Wed, 01 Aug 2018 10:21:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533144065; cv=none; d=google.com; s=arc-20160816; b=OrZ7pA3Gnv3XF5RClWq0Uia7s7qXWhgqZ/JOAq6XA7sPM51lkbOVxcVpLjYrLyYcUV AZFhCubETI8J2AkHGS1RAv4FRjn11/PN58UJV/FwerCIjyRLs68xEzJXpXRUi3/WKTSG xU1LOddbGgJrHglg06/Vn1l/ePAJHVpge1md+k4TPisKynOdBfcM435Y92415wAkGVjT Nu0cLhWCif7XbUnlQuICBQx1tIdt196gtYDhhPgR9hpf1sOVy7P6VhHlFG+f/h3b4mIP 4PPvKEaoF2Y/4Z8LnGqhWk9aEQQRh4aQZmt944SnK5e5hbdGwL5gK8SesnovenOASefj 97nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=ow2VAxcIaFLHuHKkH0x3dtrzyjUtdCEDimOKd62NKs4=; b=i7nmlXck4AmtQBi6sysR/1ioPCTbgPLkda9JZNXK3dYoiLQqDZoaItYZdCBPi799qY H6aTY3JLNmG73IxzGKvf/TI6/qtNuHsVmd3+Ccy4hpALukqLVHVUVf7QFkR5LbtX05Ux WkyXG/BedH98CKGNYxmc+D7+86Dn2Wr5Jsh4ekHQPGTS7/KJT/X2DTXFYviiH97kDG+W Gt2qGcLE0hmi2FQzorYEze4CtHPBhOnDvYo+fjqzGfQPxywxZNhSVGSEdD0ZESIRX0sU VuGU50S3mMLqt5o4WHPrnA5C/ZMN4dl9s1orIV//OyFBWay/IzAy7cs4KuovJnyHgCt5 QgdA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y23-v6si17116540pli.389.2018.08.01.10.20.51; Wed, 01 Aug 2018 10:21:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405022AbeHATFX (ORCPT + 99 others); Wed, 1 Aug 2018 15:05:23 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:47380 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403882AbeHATFW (ORCPT ); Wed, 1 Aug 2018 15:05:22 -0400 Received: from localhost (D57E6652.static.ziggozakelijk.nl [213.126.102.82]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id A9F44C96; Wed, 1 Aug 2018 17:18:41 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Luc Van Oostenryck , Alex Deucher , Sasha Levin Subject: [PATCH 4.14 137/246] drm/radeon: fix mode_valids return type Date: Wed, 1 Aug 2018 18:50:47 +0200 Message-Id: <20180801165018.296591763@linuxfoundation.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180801165011.700991984@linuxfoundation.org> References: <20180801165011.700991984@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Luc Van Oostenryck [ Upstream commit 7a47f20eb1fb8fa8d7a8fe3a4fd8c721f04c2174 ] The method struct drm_connector_helper_funcs::mode_valid is defined as returning an 'enum drm_mode_status' but the driver implementation for this method uses an 'int' for it. Fix this by using 'enum drm_mode_status' in the driver too. Signed-off-by: Luc Van Oostenryck Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/radeon/radeon_connectors.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) --- a/drivers/gpu/drm/radeon/radeon_connectors.c +++ b/drivers/gpu/drm/radeon/radeon_connectors.c @@ -853,7 +853,7 @@ static int radeon_lvds_get_modes(struct return ret; } -static int radeon_lvds_mode_valid(struct drm_connector *connector, +static enum drm_mode_status radeon_lvds_mode_valid(struct drm_connector *connector, struct drm_display_mode *mode) { struct drm_encoder *encoder = radeon_best_single_encoder(connector); @@ -1013,7 +1013,7 @@ static int radeon_vga_get_modes(struct d return ret; } -static int radeon_vga_mode_valid(struct drm_connector *connector, +static enum drm_mode_status radeon_vga_mode_valid(struct drm_connector *connector, struct drm_display_mode *mode) { struct drm_device *dev = connector->dev; @@ -1157,7 +1157,7 @@ static int radeon_tv_get_modes(struct dr return 1; } -static int radeon_tv_mode_valid(struct drm_connector *connector, +static enum drm_mode_status radeon_tv_mode_valid(struct drm_connector *connector, struct drm_display_mode *mode) { if ((mode->hdisplay > 1024) || (mode->vdisplay > 768)) @@ -1499,7 +1499,7 @@ static void radeon_dvi_force(struct drm_ radeon_connector->use_digital = true; } -static int radeon_dvi_mode_valid(struct drm_connector *connector, +static enum drm_mode_status radeon_dvi_mode_valid(struct drm_connector *connector, struct drm_display_mode *mode) { struct drm_device *dev = connector->dev; @@ -1801,7 +1801,7 @@ out: return ret; } -static int radeon_dp_mode_valid(struct drm_connector *connector, +static enum drm_mode_status radeon_dp_mode_valid(struct drm_connector *connector, struct drm_display_mode *mode) { struct drm_device *dev = connector->dev;