Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1111780imm; Wed, 1 Aug 2018 10:22:13 -0700 (PDT) X-Google-Smtp-Source: AAOMgpe8YBrLoyPnhYhUWalyByCtMxWB21EHua4CLJNHG0p5cev1PdVzbh1JTjAxM85onSOweQgB X-Received: by 2002:a62:4add:: with SMTP id c90-v6mr27960068pfj.23.1533144133189; Wed, 01 Aug 2018 10:22:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533144133; cv=none; d=google.com; s=arc-20160816; b=IK1C5Ix9YUEQkf7AuUPoMiPBlCkWRPZmOYraeecVJxPEE367Jm7JSFxZrDWK78O7yj Ru+FDK6BmaYjS97kxqznGkSZoTVgp2Xobf0Z5TackZvdCG8xy44XlL5HOHBL7qVfAagN giJ+hLT9NxJ7ojF6ifJzJm1rO3cVK3+NyAi2mMeRZexxkQ49abiI0HZuxRAFNxUH1f/J Rla+TmiZIiQ4zgzbb6ATa7hUKM6znd6UOFwT/wumEELHuExBDkhH+LNn8ogX2nw0YsjK /XxAoLsbSNnt6Fk7YRP5RCtz7XgwdeVNhijKCxhrSI96Ya9ORnSCVii9VNelGeHUsuQY fCrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=gFMHuE9q4CFk/dZO9B0gKNnQLGIegGHMeCGPSkuJIKU=; b=mOrvB3tEcvDOHUssy2fPFbDrZaJ8RgJ2+sPtCkK4Wbe/X7NaLdEeXKogU1vwa9wUOA UcZMjggicOBrLc+s5vCGOIjQOm9d5HcTQ6jOweG4QfRHEeKFeWtaoD9wgrjLxdjL7xEt XUys/n+CVqCWbnP6xD0Ghqg45MmkFaDbab/UVxalcTr6VH9XQZ2iRzSxC4XlTh6kdSVn tHBvV6qZ4rbUbvRkn0i4QIm8Gv6FFxbbzyBaneIQ2DhIWi5EobsCRc8JEj4DXdEf+hPy 3wpXwpy0s7EP1uSbC6WxIm8QAYyxhPPbOTXXOK0DOqqV/U9AoBBGGsB8ihz52gFjqvOC e7rg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n6-v6si15561853pla.398.2018.08.01.10.21.57; Wed, 01 Aug 2018 10:22:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404622AbeHATGx (ORCPT + 99 others); Wed, 1 Aug 2018 15:06:53 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:49074 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403967AbeHATGw (ORCPT ); Wed, 1 Aug 2018 15:06:52 -0400 Received: from localhost (D57E6652.static.ziggozakelijk.nl [213.126.102.82]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id B0C93CC2; Wed, 1 Aug 2018 17:20:11 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jakub Kicinski , Quentin Monnet , Daniel Borkmann , Sasha Levin Subject: [PATCH 4.14 168/246] bpf: fix references to free_bpf_prog_info() in comments Date: Wed, 1 Aug 2018 18:51:18 +0200 Message-Id: <20180801165019.775715836@linuxfoundation.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180801165011.700991984@linuxfoundation.org> References: <20180801165011.700991984@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jakub Kicinski [ Upstream commit ab7f5bf0928be2f148d000a6eaa6c0a36e74750e ] Comments in the verifier refer to free_bpf_prog_info() which seems to have never existed in tree. Replace it with free_used_maps(). Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet Signed-off-by: Daniel Borkmann Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- kernel/bpf/verifier.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/kernel/bpf/verifier.c +++ b/kernel/bpf/verifier.c @@ -4110,7 +4110,7 @@ static int replace_map_fd_with_map_ptr(s /* hold the map. If the program is rejected by verifier, * the map will be released by release_maps() or it * will be used by the valid program until it's unloaded - * and all maps are released in free_bpf_prog_info() + * and all maps are released in free_used_maps() */ map = bpf_map_inc(map, false); if (IS_ERR(map)) { @@ -4623,7 +4623,7 @@ free_log_buf: vfree(log_buf); if (!env->prog->aux->used_maps) /* if we didn't copy map pointers into bpf_prog_info, release - * them now. Otherwise free_bpf_prog_info() will release them. + * them now. Otherwise free_used_maps() will release them. */ release_maps(env); *prog = env->prog;