Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1114855imm; Wed, 1 Aug 2018 10:25:23 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcbFKLxprgP3K1bEv1HpytghTGVu/71sX4o8cxgDHtwJ4bdDi9QTgADkbsAgR4jzIcdWxjN X-Received: by 2002:a63:8a41:: with SMTP id y62-v6mr24717599pgd.291.1533144323260; Wed, 01 Aug 2018 10:25:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533144323; cv=none; d=google.com; s=arc-20160816; b=jMw+Haa5eEqlRr3/ssTgQ7vRmrCN+wWmycAkeELejKjb3D46jyL8Rtl3Z1fduSxiC3 xLkTk3vIN32bDypIx/enzbULvKnoBcE61LKN9C2MoMspDaHeQ3LRgD+WRGVHRlO+MqbE dDsXin+JMhHP4h3nODkvCIn7lSZeiFPO+8+TJ7Nnlg7JMbGvn7LTsnLcXGFxRgTkBl6R rTiTcQdJK1HVG9lDoGuqfgPQ6Q62frQL1smD6gVUlC7xbm0KIs+TpouAXz+GM/gxTOqv 9P6MUisPq8yO/KhEPZwVbuts2aJv3GhswDPZ7fR2jOAGWIyDYST43d0sIncWIdjQiM7+ Xa5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=7nYzZkU2ZtcyDcyS8S+go8wdj5ZT+GE6Sq3RjL9jC/k=; b=xcSUz4rbdY4h6EfOc77uhMxOSbfEx2wsLHOWSYI0h/fuALoRQN8s8AMMFwPQmWbQVB bqKyFPGWbY63UxHkQE8eZ9y6ihR+jxNYnLuVxulvwHJaIKADpM90sGv6rQq76oh9NtJ5 5mRG7ZK7M47zBMWFrCnLiE+HZA01NU6jXkwFVs4OVUO3LRvyCgaDlRJKu/3cp0RZBWuv QeRukTsIo+NRnCsecW8+OV1EKIhTJnKx7H0BA4Llefrg+gnfCBpvOfgInt8dqFkUo+7Z W7/lktYvjALILY7b2vsa+nfEHTUpFZChXV4vSRvhaErWtdSPJWObs/1LFHTr3QMYpnEO uBfw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 5-v6si16597205pgp.439.2018.08.01.10.25.08; Wed, 01 Aug 2018 10:25:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406433AbeHATKf (ORCPT + 99 others); Wed, 1 Aug 2018 15:10:35 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:51032 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389790AbeHATKe (ORCPT ); Wed, 1 Aug 2018 15:10:34 -0400 Received: from localhost (D57E6652.static.ziggozakelijk.nl [213.126.102.82]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 7CCCCD27; Wed, 1 Aug 2018 17:23:52 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "David S. Miller" , Herbert Xu , Steffen Klassert , netdev@vger.kernel.org, Dmitry Safonov Subject: [PATCH 4.14 240/246] netlink: Do not subscribe to non-existent groups Date: Wed, 1 Aug 2018 18:52:30 +0200 Message-Id: <20180801165023.229724039@linuxfoundation.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180801165011.700991984@linuxfoundation.org> References: <20180801165011.700991984@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dmitry Safonov [ Upstream commit 7acf9d4237c46894e0fa0492dd96314a41742e84 ] Make ABI more strict about subscribing to group > ngroups. Code doesn't check for that and it looks bogus. (one can subscribe to non-existing group) Still, it's possible to bind() to all possible groups with (-1) Cc: "David S. Miller" Cc: Herbert Xu Cc: Steffen Klassert Cc: netdev@vger.kernel.org Signed-off-by: Dmitry Safonov Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/netlink/af_netlink.c | 1 + 1 file changed, 1 insertion(+) --- a/net/netlink/af_netlink.c +++ b/net/netlink/af_netlink.c @@ -976,6 +976,7 @@ static int netlink_bind(struct socket *s if (err) return err; } + groups &= (1UL << nlk->ngroups) - 1; bound = nlk->bound; if (bound) {