Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261491AbTIXQjS (ORCPT ); Wed, 24 Sep 2003 12:39:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261498AbTIXQjS (ORCPT ); Wed, 24 Sep 2003 12:39:18 -0400 Received: from pix-525-pool.redhat.com ([66.187.233.200]:23195 "EHLO devserv.devel.redhat.com") by vger.kernel.org with ESMTP id S261491AbTIXQjP (ORCPT ); Wed, 24 Sep 2003 12:39:15 -0400 Date: Wed, 24 Sep 2003 12:38:58 -0400 From: Pete Zaitcev To: Alan Cox Cc: Pete Zaitcev , Chris Wright , Marcelo Tosatti , Linux Kernel Mailing List , mc@cs.stanford.edu Subject: Re: [CHECKER] 32 Memory Leaks on Error Paths Message-ID: <20030924123858.B4714@devserv.devel.redhat.com> References: <20030923140503.N20572@osdlab.pdx.osdl.net> <20030924001334.A19940@devserv.devel.redhat.com> <1064407793.13459.17.camel@dhcp23.swansea.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <1064407793.13459.17.camel@dhcp23.swansea.linux.org.uk>; from alan@lxorguk.ukuu.org.uk on Wed, Sep 24, 2003 at 01:49:54PM +0100 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 690 Lines: 19 > > - spin_lock(&codec->ac97_lock); > > + down(&unit->ac97_lock); > > /* XXX Do make use of dev->id */ > > - ymfpci_codec_ready(codec, 0, 0); > > This breaks ac97 locking and should not be applied. The core ac97 > code is called some times with interrupts disabled. That is unavoidable. > > The only change that is relevant is the kfree In that case, whoever added spinlocks should have removed schedule() from ymfpci_ready_wait(). -- Pete - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/