Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 01 Aug 2018 10:55:28 -0700 (PDT)
Subject:     Re: [PATCH v2] riscv: Add support to no-FPU systems
In-Reply-To: <1530073346-5341-1-git-send-email-alankao@andestech.com>
CC:     albert@sifive.com, linux-riscv@lists.infradead.org,
        linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
        Christoph Hellwig <hch@infradead.org>,
        Andrew Waterman <andrew@sifive.com>,
        Darius Rad <darius@bluespec.com>, greentime@andestech.com,
        zong@andestech.com, alankao@andestech.com
From:   Palmer Dabbelt <palmer@sifive.com>
To:     alankao@andestech.com
Message-ID: <mhng-47d9ea80-a0c6-4cde-be65-75046c5d49d2@palmer-si-x1c4>
Mime-Version: 1.0 (MHng)
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 26 Jun 2018 21:22:26 PDT (-0700), alankao@andestech.com wrote:
> This patch adds an option, CONFIG_FPU, to enable/disable floating
> procedures.  Also, some style issues are fixed.
>
> Signed-off-by: Alan Kao <alankao@andestech.com>
> Cc: Greentime Hu <greentime@andestech.com>
> Cc: Zong Li <zong@andestech.com>
> ---
>  arch/riscv/Kconfig                 |  9 ++++
>  arch/riscv/Makefile                | 19 +++----
>  arch/riscv/include/asm/switch_to.h |  6 +++
>  arch/riscv/kernel/entry.S          |  3 +-
>  arch/riscv/kernel/process.c        |  7 ++-
>  arch/riscv/kernel/signal.c         | 82 +++++++++++++++++++++---------
>  6 files changed, 90 insertions(+), 36 deletions(-)
>
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> index 6debcc4afc72..6069597ba73f 100644
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -232,6 +232,15 @@ config RISCV_BASE_PMU
>
>  endmenu
>
> +config FPU
> +	bool "FPU support"
> +	default y
> +	help
> +	  Say N here if you want to disable all floating-point related procedure
> +	  in the kernel.
> +
> +	  If you don't know what to do here, say Y.
> +
>  endmenu

Sorry for letting this slide for a bit.  While I'm not opposed to a solution 
that requires a FPU Kconfig option, it'd be a bit better if we could detect 
this at boot time.  I think this should be possible because at one point this 
actually worked and we could boot the same kernel on FPU and no-FPU systems.

If that's not possible then we'll have to take something like this.  There were 
some comments on this v2 but I don't see a v3, did I miss one?