Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261500AbTIXWhD (ORCPT ); Wed, 24 Sep 2003 18:37:03 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261592AbTIXWhD (ORCPT ); Wed, 24 Sep 2003 18:37:03 -0400 Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:12524 "EHLO www.linux.org.uk") by vger.kernel.org with ESMTP id S261500AbTIXWhA (ORCPT ); Wed, 24 Sep 2003 18:37:00 -0400 Date: Wed, 24 Sep 2003 23:36:57 +0100 From: viro@parcelfarce.linux.theplanet.co.uk To: Linus Torvalds Cc: Marcelo Tosatti , lkml , olof@austin.ibm.com Subject: Re: [PATCH] [2.4] Re: /proc/ioports overrun patch Message-ID: <20030924223657.GB7665@parcelfarce.linux.theplanet.co.uk> References: <20030924195133.GY7665@parcelfarce.linux.theplanet.co.uk> <20030924195926.GZ7665@parcelfarce.linux.theplanet.co.uk> <20030924214713.GA7665@parcelfarce.linux.theplanet.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030924214713.GA7665@parcelfarce.linux.theplanet.co.uk> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 697 Lines: 12 Umm... Linus, output truncation is 2.4 problem; any seq_file-based variant (including one already in 2.6 and being backported to 2.4) solves that. The thing being, variant we had in 2.6 was ugly - it had walk through the tree shoved into ->show() instead of having the iterator do that for us. And that's what this patch fixed - it's not that old 2.6 variant would break, it's that it was done in wrong way. IOW, changeset comment is misleading... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/