Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1340315imm; Wed, 1 Aug 2018 14:17:00 -0700 (PDT) X-Google-Smtp-Source: AAOMgpf4p2ekARGH3AlDyp3aFzQ7JyJINMVXmsPQZc6uuhei1vDBG7zoYVEyEMTxGkgyX6Un99ZG X-Received: by 2002:a62:5f82:: with SMTP id t124-v6mr28659635pfb.223.1533158220931; Wed, 01 Aug 2018 14:17:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533158220; cv=none; d=google.com; s=arc-20160816; b=AFIZXC+gtAhB0Ps8NyxZq/8UOBbLulr1CXshfm2Wr54oZUlfkM37WmgAjDYuMmgvWu O9DXFl7uj7ph6bikEBsV6JRMD5LN29RjKlb68Ho5ToJ0CNQJmVCb1s0JInwMs7guiKPO H9yNdB/SyyL4FXp5yEcEGI1pPXuLqTEEH8ob2iD6tV9OQuEE864C30nDZ3u1V0x1JhjO FJSbuqGRNTfZXHYjBh9wdHB358s6byGgSryCnOnICYwv6ggXaYu6K2+S6MIP+XLxFyJm zMzPbd/P5dpoSNX45t23dE2PRxMacvf2A6actyfM45KrpqndNg0PSMUtvXjxUVl0OH1N dYPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=T7Z37qquT6jxhQplQC9YbdqrL/7bk8ctwD3Jb2cOcHE=; b=X0VabWzY2kM4TqmCv3WA2BGSRFqRY95ubVqFoVrQ8ULuUyhji9XtVbCYlIFcfPahCK KeoMn3TTiy0n8+5MLGwTvhSmKJWrQ8o1u6/t4VTKcfGKWMsVAwKtCBHthTB1HYreWXTN i9sFMY/Fl5f9xK9E3jlo9c+/njw/YnEFsPw4uzszl2nVaZpLjb5sv0Ihpsjvt6Uax+2C PlUXqCf9/M5IBO1qjqwjLK+JUVaWl4mjw17rdMghLDCdQTowEMy/Kx0qtRj/JX4W8/Js eUkzHACDxI74wtNwDgMMpt122YCsiVlT2QYRkZ5EZ4neeLflAMF5eywb5TcSouLLrhZW 4rvg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t16-v6si31803pgj.234.2018.08.01.14.16.46; Wed, 01 Aug 2018 14:17:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732191AbeHAXC7 (ORCPT + 99 others); Wed, 1 Aug 2018 19:02:59 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:58996 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726043AbeHAXC6 (ORCPT ); Wed, 1 Aug 2018 19:02:58 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 869B640241D5; Wed, 1 Aug 2018 21:15:16 +0000 (UTC) Received: from malachite.bss.redhat.com (dhcp-10-20-1-11.bss.redhat.com [10.20.1.11]) by smtp.corp.redhat.com (Postfix) with ESMTP id 363862026D68; Wed, 1 Aug 2018 21:15:16 +0000 (UTC) From: Lyude Paul To: nouveau@lists.freedesktop.org Cc: Lukas Wunner , Peter Ujfalusi , stable@vger.kernel.org, Ben Skeggs , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 2/8] drm/nouveau: Enable polling even if we have runtime PM Date: Wed, 1 Aug 2018 17:14:52 -0400 Message-Id: <20180801211459.7731-3-lyude@redhat.com> In-Reply-To: <20180801211459.7731-1-lyude@redhat.com> References: <20180801211459.7731-1-lyude@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Wed, 01 Aug 2018 21:15:16 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Wed, 01 Aug 2018 21:15:16 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lyude@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Having runtime PM makes no difference on whether or not we want polling, and it's now safe to just enable polling unconditionally in drm_load() thanks to d61a5c106351 ("drm/nouveau: Fix deadlock on runtime suspend") Signed-off-by: Lyude Paul Cc: Lukas Wunner Cc: Peter Ujfalusi Cc: stable@vger.kernel.org --- drivers/gpu/drm/nouveau/nouveau_drm.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c index 5fdc1fbe2ee5..ee2546db09c9 100644 --- a/drivers/gpu/drm/nouveau/nouveau_drm.c +++ b/drivers/gpu/drm/nouveau/nouveau_drm.c @@ -592,10 +592,11 @@ nouveau_drm_load(struct drm_device *dev, unsigned long flags) pm_runtime_allow(dev->dev); pm_runtime_mark_last_busy(dev->dev); pm_runtime_put(dev->dev); - } else { - /* enable polling for external displays */ - drm_kms_helper_poll_enable(dev); } + + /* enable polling for connectors without hpd */ + drm_kms_helper_poll_enable(dev); + return 0; fail_dispinit: -- 2.17.1