Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1501661imm; Wed, 1 Aug 2018 17:45:18 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfFvNjqwLMKUgd+QvRO7zxnajqlKqsMEcLz18vW1GTDzH4mM07erW8hT2SgnXg3JpTnSJ+T X-Received: by 2002:a17:902:9a8b:: with SMTP id w11-v6mr432827plp.333.1533170718417; Wed, 01 Aug 2018 17:45:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533170718; cv=none; d=google.com; s=arc-20160816; b=T49A8VqKcUAPskvIGpXqzwBLXSecnPRth2jMDdhmQrer4LH1zj4Tr5S5nQpSvF5TXb GzeHcV/+35dOWQWp1n7n7E2nuiXRLD9Eal+DtcvnqsAIK/Tc+Ubh1D4zSPpg3aMVNUHr U+XS2RODlanEwLobVvwlUcqwP1bIGS1jl/ewKzHxWvmsegoqx8/+9ogrJa2OzMjmal27 78KT7bdZhcZKvX9HwFF3nT3muLenqu0nZM48o/KnhjRfrmgAohioMAcR+R9bQCzyzc3z G2625/C3aMz8qiOSwq4kzH7IsHHcZy7IkWkpmZPzR/tkK541rCbfc/cXd5n/FRagRbca 5s6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date :arc-authentication-results; bh=WFQ4p+V9tp2vJJhZ/WwI+4dT/q4pmdRT6AE7dhRSDx4=; b=iiexG2pt4a42WAQ3lqwAOSy/utmWcHaM2uQZmOZp9mk8sySlm1enOR+mm+9otb7m+g GDyrd5Xz4BMgN3DNLC3cQyVg5Wf8avcDxq3LMGTsSulS44D7bPRBEbTF4aFCBI28rPwb mhN//wyWDJ97e5NKxxIVysUu01WS3f/fUqPndz9AbiPrzfStx+R1PM3DLl2peag6vLz7 aQ97Vaj/R8jOANmKgXeZK1NqM4uvsq4b1apHjJQdCPThQz14EMSZBpOqu5pqM3Rdivp+ 9J27saBoWyRawa/dbQmJ7DCjNFRu6eQRX3SK0Nj/7fjuGUcz+GfwnLucc9qMFFqnu45D vvXA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 1-v6si463067pgb.107.2018.08.01.17.45.03; Wed, 01 Aug 2018 17:45:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731333AbeHBCce (ORCPT + 99 others); Wed, 1 Aug 2018 22:32:34 -0400 Received: from gateway30.websitewelcome.com ([192.185.180.41]:40631 "EHLO gateway30.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730431AbeHBCce (ORCPT ); Wed, 1 Aug 2018 22:32:34 -0400 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 923E834C6 for ; Wed, 1 Aug 2018 19:44:06 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id l1iofIG8bRPojl1iofnT7R; Wed, 01 Aug 2018 19:44:06 -0500 X-Authority-Reason: nr=8 Received: from [189.250.61.218] (port=43344 helo=embeddedor) by gator4166.hostgator.com with esmtpa (Exim 4.91) (envelope-from ) id 1fl1io-001vSv-2B; Wed, 01 Aug 2018 19:44:06 -0500 Date: Wed, 1 Aug 2018 19:44:05 -0500 From: "Gustavo A. R. Silva" To: "J. Bruce Fields" , Jeff Layton Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] nfsd: use true and false for boolean values Message-ID: <20180802004405.GA23995@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.250.61.218 X-Source-L: No X-Exim-ID: 1fl1io-001vSv-2B X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedor) [189.250.61.218]:43344 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 13 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return statements in functions returning bool should use true or false instead of an integer value. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- fs/nfsd/nfsfh.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/nfsd/nfsfh.c b/fs/nfsd/nfsfh.c index a008e76..b319080 100644 --- a/fs/nfsd/nfsfh.c +++ b/fs/nfsd/nfsfh.c @@ -451,7 +451,7 @@ static bool fsid_type_ok_for_exp(u8 fsid_type, struct svc_export *exp) switch (fsid_type) { case FSID_DEV: if (!old_valid_dev(exp_sb(exp)->s_dev)) - return 0; + return false; /* FALL THROUGH */ case FSID_MAJOR_MINOR: case FSID_ENCODE_DEV: @@ -461,13 +461,13 @@ static bool fsid_type_ok_for_exp(u8 fsid_type, struct svc_export *exp) case FSID_UUID8: case FSID_UUID16: if (!is_root_export(exp)) - return 0; + return false; /* fall through */ case FSID_UUID4_INUM: case FSID_UUID16_INUM: return exp->ex_uuid != NULL; } - return 1; + return true; } -- 2.7.4