Date: Thu, 25 Sep 2003 07:23:43 +0100
From: Christoph Hellwig <hch@infradead.org>
To: Steven Dake <sdake@mvista.com>
Cc: linux-kernel@vger.kernel.org, mochel@osdl.org
Subject: Re: [PATCH} fix defect with kobject memory leaks during del_gendisk
Message-ID: <20030925072343.A4636@infradead.org>
Mail-Followup-To: Christoph Hellwig <hch@infradead.org>,
	Steven Dake <sdake@mvista.com>, linux-kernel@vger.kernel.org,
	mochel@osdl.org
References: <1064444526.13033.355.camel@persist.az.mvista.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <1064444526.13033.355.camel@persist.az.mvista.com>; from sdake@mvista.com on Wed, Sep 24, 2003 at 04:02:06PM -0700
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 805
Lines: 16

On Wed, Sep 24, 2003 at 04:02:06PM -0700, Steven Dake wrote:
> Unfortunately it appears that del_gendisk uses kobject_del to delete the
> kobject.  If the kobject has a ktype release function, it is not called
> in the kobject_del call path, but only in kobject_unregister.

That's intentional.  gendisks (like everything using kobjects) are
reference counted and ->release is unly called after the last reference
goes away, for gendisks that would be the last put_disk call.

Unless you miss the put_disk call (which md certainly has) there's
no memeory leak.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/