Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   zhong jiang <zhongjiang@huawei.com>
To:     <andy.shevchenko@gmail.com>, <john.garry@huawei.com>,
        <jejb@linux.vnet.ibm.com>, <martin.petersen@oracle.com>,
        <aacraid@microsemi.com>
CC:     <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH 2/2] scsi:qlogicfas408: remove the same check in qlogicfas408_detect
Date:   Thu, 2 Aug 2018 10:45:01 +0800
Message-ID: <1533177901-19514-3-git-send-email-zhongjiang@huawei.com>
In-Reply-To: <1533177901-19514-1-git-send-email-zhongjiang@huawei.com>
References: <1533177901-19514-1-git-send-email-zhongjiang@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

we should not use same check in a expression. just remove one
of them.

Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
 drivers/scsi/qlogicfas408.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/scsi/qlogicfas408.c b/drivers/scsi/qlogicfas408.c
index 8b471a9..1409ac1 100644
--- a/drivers/scsi/qlogicfas408.c
+++ b/drivers/scsi/qlogicfas408.c
@@ -567,8 +567,7 @@ void qlogicfas408_setup(int qbase, int id, int int_type)
 int qlogicfas408_detect(int qbase, int int_type)
 {
         REG1;
-	return (((inb(qbase + 0xe) ^ inb(qbase + 0xe)) == 7) &&
-	       ((inb(qbase + 0xe) ^ inb(qbase + 0xe)) == 7));		
+	return (inb(qbase + 0xe) ^ inb(qbase + 0xe)) == 7;
 }
 
 /*
-- 
1.7.12.4