Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1608957imm; Wed, 1 Aug 2018 20:23:20 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdC+EkYJAPaZazutvO1XyawQpPWmNVtHz0gpTcCAhwt840HsCXEees1td1kF7FCXD/jNmAj X-Received: by 2002:a63:f713:: with SMTP id x19-v6mr942937pgh.233.1533180200103; Wed, 01 Aug 2018 20:23:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533180200; cv=none; d=google.com; s=arc-20160816; b=YO3wKTNt4fOs6Df8RGQhEgvTzUarE6l8Ot1plsM8NsjyTJWCtBIgqmCSm1YbnV4kg+ 2gsp4N2X2I0HG903Ftje2tCzACtJHmMvRqlqSNZXfaTXz+jNZcSqMGggT8WMm+M5V/gU H5JoDbAPKvoLF/60RR7pYrENn990TcsrF8kzUxeUAHima+EdSQlsobAwBEsR+vEuw5A+ Ebe7x6ngo4JOFB/EUdSvzBSrkTYM2g72kB9B/gdss66AyP0YNqsB3tnxYCVC2qTjJ5Y3 8dx1IuFrpWCQPP5FK44hLFUKMSn4jZwcvdKD5qvbE53FTdiXZedLuOrM3djTGgmXHbmX lG7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:arc-authentication-results; bh=S7QBTzyYyF9i8HDWEZ+WbKIaO54SsGphz7TYFtOiL9A=; b=zEIT2Rvxc5QzBQHJOksLtbVAq3TSoR4PPuWv9e/bsJVul0MpQ+0tYkzO7TEsqBzzwn HZCbNkuFtYeH/Uq9WzBnu8e1b1p/hPBTfDKFVFt9shVlKPamNXDw0w8wKkT/MCZhZxwt jha+6m36yvzWOtb1805sN/1HFQbZiiLTP1VFSBFZ8cBtQRvXK7WuTW4bn6riz0GQtaYW HYIS3/aqKsUw0/rG4fzZsj0eRmE4Z/FQyHoXd5f7/Plnu+pA9wCCoxrAyGo1gs1DKa+a ptxsiXkgscu9RJCQtlSd9wGrXgtobtYDCJ7zb67ZZoeiq/rQBTVqzpSPzMbWbhxoLHWF 7ZvQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y8-v6si859633pfk.75.2018.08.01.20.23.05; Wed, 01 Aug 2018 20:23:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726967AbeHBFK4 (ORCPT + 99 others); Thu, 2 Aug 2018 01:10:56 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:44388 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726679AbeHBFKz (ORCPT ); Thu, 2 Aug 2018 01:10:55 -0400 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id AF6FB26C5E0F4; Thu, 2 Aug 2018 11:21:51 +0800 (CST) Received: from linux-ibm.site (10.175.102.37) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.399.0; Thu, 2 Aug 2018 11:21:44 +0800 From: zhong jiang To: , , , CC: , , , Subject: [PATCH] scsi:NCR5380: remove same check condition in NCR5380_select Date: Thu, 2 Aug 2018 11:10:08 +0800 Message-ID: <1533179408-20631-1-git-send-email-zhongjiang@huawei.com> X-Mailer: git-send-email 1.7.12.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.102.37] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The same check condition is redundant, so remove one of them. Signed-off-by: zhong jiang --- drivers/scsi/NCR5380.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c index 90ea0f5..2ecaf3f 100644 --- a/drivers/scsi/NCR5380.c +++ b/drivers/scsi/NCR5380.c @@ -999,8 +999,7 @@ static struct scsi_cmnd *NCR5380_select(struct Scsi_Host *instance, /* Check for lost arbitration */ if ((NCR5380_read(INITIATOR_COMMAND_REG) & ICR_ARBITRATION_LOST) || - (NCR5380_read(CURRENT_SCSI_DATA_REG) & hostdata->id_higher_mask) || - (NCR5380_read(INITIATOR_COMMAND_REG) & ICR_ARBITRATION_LOST)) { + (NCR5380_read(CURRENT_SCSI_DATA_REG) & hostdata->id_higher_mask)) { NCR5380_write(MODE_REG, MR_BASE); dsprintk(NDEBUG_ARBITRATION, instance, "lost arbitration, deasserting MR_ARBITRATE\n"); spin_lock_irq(&hostdata->lock); -- 1.7.12.4