Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 02 Aug 2018 07:27:08 +0200
Message-ID: <s5hr2jhxrrn.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     "Wei Yongjun" <weiyongjun1@huawei.com>
Cc:     "Jorge Sanjuan" <jorge.sanjuan@codethink.co.uk>,
        "Michael Drake" <michael.drake@codethink.co.uk>,
        "Ruslan Bilovol" <ruslan.bilovol@gmail.com>,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
        "Jaroslav Kysela" <perex@perex.cz>,
        "MarkusElfring" <elfring@users.sourceforge.net>,
        <alsa-devel@alsa-project.org>, <kernel-janitors@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] ALSA: usb-audio: Fix invalid use of sizeof in parse_uac_endpoint_attributes()
In-Reply-To: <1533184262-148619-1-git-send-email-weiyongjun1@huawei.com>
References: <1533184262-148619-1-git-send-email-weiyongjun1@huawei.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/26
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 02 Aug 2018 06:31:02 +0200,
Wei Yongjun wrote:
> 
> sizeof() when applied to a pointer typed expression gives the
> size of the pointer, not that of the pointed data.
> 
> Fixes: 7edf3b5e6a45 ("ALSA: usb-audio: AudioStreaming Power Domain parsing")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

Applied, thanks.


Takashi

> ---
>  sound/usb/stream.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/usb/stream.c b/sound/usb/stream.c
> index 8fe3b0e..67cf849 100644
> --- a/sound/usb/stream.c
> +++ b/sound/usb/stream.c
> @@ -1037,7 +1037,7 @@ static int parse_uac_endpoint_attributes(struct snd_usb_audio *chip,
>  		fp->rate_max = UAC3_BADD_SAMPLING_RATE;
>  		fp->rates = SNDRV_PCM_RATE_CONTINUOUS;
>  
> -		pd = kzalloc(sizeof(pd), GFP_KERNEL);
> +		pd = kzalloc(sizeof(*pd), GFP_KERNEL);
>  		if (!pd) {
>  			kfree(fp->rate_table);
>  			kfree(fp);
> 
>