Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 2 Aug 2018 09:05:12 +0200 (CEST)
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Chao Fan <fanc.fnst@cn.fujitsu.com>
cc:     Dou Liyang <douly.fnst@cn.fujitsu.com>,
        linux-kernel@vger.kernel.org, x86@kernel.org, hpa@zytor.com,
        mingo@redhat.com, bhe@redhat.com, keescook@chromium.org,
        yasu.isimatu@gmail.com, indou.takao@jp.fujitsu.com,
        caoj.fnst@cn.fujitsu.com
Subject: Re: [PATCH v4 3/4] x86/boot/KASLR: Walk srat tables to filter
 immovable memory
In-Reply-To: <20180802035413.GC6723@localhost.localdomain>
Message-ID: <alpine.DEB.2.21.1808020857130.1835@nanos.tec.linutronix.de>
References: <20180723092908.32656-1-fanc.fnst@cn.fujitsu.com> <20180723092908.32656-4-fanc.fnst@cn.fujitsu.com> <18d27595-43d8-d2a0-bfdf-bd731b77d1b9@cn.fujitsu.com> <20180802035413.GC6723@localhost.localdomain>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 2 Aug 2018, Chao Fan wrote:
> On Thu, Aug 02, 2018 at 11:47:13AM +0800, Dou Liyang wrote:

Removed 70 lines of complete useless information....

> >> +	table = (struct acpi_subtable_header *)
> >> +		((unsigned long)table_header + sizeof(struct acpi_table_srat));
> >> +
> >> +	table_size = sizeof(struct acpi_subtable_header);
> >
> >table_size isn't used, can be remove.
> >
> 
> Thank you very much, will update in next version.

And yet another 40 lines.

> 

Folks. Can you please both stop this annoying habit of keeping the full
context of the mail and then sprinkling a random sentence into the middle?

Thanks,

	tglx