Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1813826imm; Thu, 2 Aug 2018 01:13:23 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcMCeYCY0frxWH8CENPQs0A6/TToxsPqdj1JsI/999AhMiBEirklkzgi+Y/GRONDCAw1Nd4 X-Received: by 2002:a62:5cc1:: with SMTP id q184-v6mr1844954pfb.241.1533197603547; Thu, 02 Aug 2018 01:13:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533197603; cv=none; d=google.com; s=arc-20160816; b=QbY4tYK+e5pWShE6tWNqF17Er+29DS+c9ipyPqTxWYfLLXY1XVEkguktUV26qqWZu5 okz5xXNsjSYFt6O6RT7kP95upfME65yvhXxw2mHQvmjuzAvjxQ4y19aSmZDCpzRktap4 uCyVGVTWqGejf+zrRtsQmq42r/1lgJ1+u1nh8KYyE8wKhvCthpt0unAbHpdjkd3dMwFr J7vkhjquwYMfItgIw1utT2JWzjQpMoxbC/pypiKKhNtpZ/VZkdrzOOh0tlbEKifE2uX7 99+DhuaRnCTEG6dRx+KqLUtmNL8chrrcqodBrzs38BgOwLPwygQ8QCG6mdVOBgGQ00jX LVMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=omwlV8q0iNRZOa6BeiCMQCqubGTQtfKwfTqrEVG5MEE=; b=eMrPZB4HgKJpvfqqT5wrzsfl2Q0sHytJH8oISD9kD3wPs6w1b0T8TPiXINRt4WStsg rKzRLGvlBZLBYL8WFLm4DJkL96HJeX624AjdhLZi5lKl0LF6dSfutrTlufyY14MtLbNq UN4NwX24VrN1fe8qVw1i/cbO+QBEssc2dIKrBLbpBEr/SgsXZXMmKZHraf0ZRhxy9flc g1PpUqSMAr+B2J0NkJ3YBtTPu/sKhmJ+pw8osVnkr5IgYlTDH/oc4ac18fOhHrXIEn3y N8DJSyqAP//HKvk8ueLbqjnzNkLpab4e2/iHFai5TD/2hYLCvdUtNjGqb9WxTN0T/lQw wuxg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g4-v6si967588plm.181.2018.08.02.01.13.09; Thu, 02 Aug 2018 01:13:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731846AbeHBKB5 (ORCPT + 99 others); Thu, 2 Aug 2018 06:01:57 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:37924 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726739AbeHBKB4 (ORCPT ); Thu, 2 Aug 2018 06:01:56 -0400 Received: from localhost (D57E6652.static.ziggozakelijk.nl [213.126.102.82]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id A565CCC3; Thu, 2 Aug 2018 08:11:56 +0000 (UTC) Date: Thu, 2 Aug 2018 10:11:54 +0200 From: Greg KH To: rkir@google.com Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/3] tty: Replace goldfish_tty_line_count with a #define Message-ID: <20180802081154.GA27413@kroah.com> References: <20180725005133.107823-1-rkir@google.com> <20180725005133.107823-3-rkir@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180725005133.107823-3-rkir@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 24, 2018 at 05:51:33PM -0700, rkir@google.com wrote: > From: Roman Kiryanov > > The driver never mutates this variable - no benefits of > keeping it mutable. > > Signed-off-by: Roman Kiryanov > --- > Changes in v2: > - Replaced "const u32" with "#define". > > drivers/tty/goldfish.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) Does not apply to my tree :(