From: Rusty Russell <rusty@rustcorp.com.au>
To: davidm@HPL.HP.COM
Cc: akpm@zip.com.au, neilb@cse.unsw.edu.au, braam@clusterfs.com,
       davem@redhat.com, Martin Schwidefsky <schwidefsky@de.ibm.com>,
       tridge@samba.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sysctl-controlled number of groups. 
In-reply-to: Your message of "Wed, 24 Sep 2003 21:19:39 MST."
             <16242.27867.715648.392875@napali.hpl.hp.com> 
Date: Thu, 25 Sep 2003 18:08:25 +1000
Message-Id: <20030925082720.9E6542C3B6@lists.samba.org>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1251
Lines: 30

In message <16242.27867.715648.392875@napali.hpl.hp.com> you write:
> >From the ia64-side, it looks mostly fine to me.  Some minor things:
> 
>  - Typo in first sentence of patch comment (can be -> to be ?)

Thanks, fixed.

>  - If I'm reading the patch right, there will be identical sys32_getgroups16()
>    definitions in .../ia32/sys_ia32.c and and compat_linux.c; did you mean
>    to name the latter compat_getgroups16()?  (ditto for setgroups16 and s390
>    and sparc64, i think)

You're not reading it right: I didn't change the names, but since
these (your) versions call the normal ones, I added the extern decl.

>  - I suspect removing NGROUPS from param.h will break glibc and/or user-level
>    apps.  param.h is one of those kernel files that are directly exposed
>    to user-level; may want to keep NGROUPS inside an #ifndef __KERNEL__.

AFAICT, they should use NGROUPS_MAX from limits.h, which I left.

Thanks,
Rusty.
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/