Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1906553imm; Thu, 2 Aug 2018 03:06:57 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcfiov/Y2Ce1rfzIgUntOEfebKawp23wa9FiSpnBLitnnq/h2KcdCYnbbdmpG3m5ZlDoMKA X-Received: by 2002:a63:5c10:: with SMTP id q16-v6mr2090887pgb.452.1533204417095; Thu, 02 Aug 2018 03:06:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533204417; cv=none; d=google.com; s=arc-20160816; b=KAd5gjY4b7JpLYOI3iRlnUqG+W5xxCpYaJGWPE1otmK7NjsP1ablUBeNk2WSE2UfUu 5JT+nKc7n663sS2eWbpo2JJrDj1n8vnUMBUOnTFSzho/MWDsu1dObQmunSgfsYL0lX2O a316N3mvtQvs1ioYXD6DfRUpqi8qSxGDLP/lp6ZTHp+xg3y2/Qkexds8gKN/4jELGyFE RCyS5FG6DvG/ODsxLrcfGDpmA65DR2MdFK0fg4VRnwrhl1UB3C7TMjv9H+QvxOezDIzD +DECtqdldvMOTdZ2S+b3p6rh+Q7bzasF7cxCpHS5Uc2olxKdmiHAUuT5hFnMFd67z7CK jrzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=QWTTubVQE6xDeeQ+j+xY/c9yjAtGJp9ZdSEgYsPLlys=; b=qEPdwBBMCVW5VzDvIViS0gyRjmuY9reY2JrIotjzxSoV4MYF4stfakU+v+eJmunMBm yyH2QEZgljTA2GJGyjvVBiyFJrdZwZdCoPuszfoWYUZ7IlhqtmkqXq27Hrr9YcmfWsJX nP+D1zGYZjqWzQq/L4ecgt3MvhaRh26BEnUmcGTa6eBF3RwsiRzOlNjbEX+Gwh7/cCQU D0QRqa7/oKgfpS+pUy17M5u6aPJVzLjtMqWjM25cOXyWj1+vzMG6W9lbgnhnKhbMjzre mZ2ZexRQwEZfLoJmP2OHO1gpJmZnubx9y0hufjXDpbwvJgWOAW5lPNm6n+f/zXRL/+E9 Xx1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=qQzMnYKb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m124-v6si1740759pgm.120.2018.08.02.03.06.42; Thu, 02 Aug 2018 03:06:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=qQzMnYKb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731555AbeHBLzq (ORCPT + 99 others); Thu, 2 Aug 2018 07:55:46 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:49320 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726277AbeHBLzq (ORCPT ); Thu, 2 Aug 2018 07:55:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=QWTTubVQE6xDeeQ+j+xY/c9yjAtGJp9ZdSEgYsPLlys=; b=qQzMnYKbOKPymgtt8WpQpWPG3 aNJv8TufzeVL7HECXm6RGfWry932G9ItBS0HAd8ngLP3eenOwpZkiVKIGX2o2IDSX1QEDaloVToym QT39+0dqs5LwIKipJlRERwyKqPkbb6qDXwseFhfMk7HexRJac6O/avSbnaQNegE+Tg3I0F+m13Y53 1zb9wiF+IHMvZ6mW6Cj4020vdiimbLFf10PG1P0kLiXz2Renxuj3FVgjLjaJfdPensh5I5k8a6N2V kM8GHIfjfw4662XtBRNscKVBCR0CoupU0Ao3HlwZptGyY+TivSik9vnz9/rziON24DQWYkTUN3jAy zah5JInLg==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1flATu-0002P5-Cs; Thu, 02 Aug 2018 10:05:18 +0000 Date: Thu, 2 Aug 2018 03:05:18 -0700 From: Christoph Hellwig To: Zong Li Cc: palmer@sifive.com, aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, greentime@adnestech.com Subject: Re: [PATCH] RISC-V: Add the directive for alignment of stvec's value Message-ID: <20180802100518.GA4144@infradead.org> References: <1529545207-26999-1-git-send-email-zong@andestech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1529545207-26999-1-git-send-email-zong@andestech.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 21, 2018 at 09:40:07AM +0800, Zong Li wrote: > The stvec's value must be 4 byte alignment by specification definition. > This directive avoids to stvec be set the non-alignment value by the > following code in head.S > > /* Point stvec to virtual address of intruction after satp write */ > la a0, 1f > add a0, a0, a1 > csrw stvec, a0 > > Signed-off-by: Zong Li Just noticed this didn't get picked up yet, so: Reviewed-by: Christoph Hellwig