Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2373418imm; Thu, 2 Aug 2018 10:28:23 -0700 (PDT) X-Google-Smtp-Source: AAOMgpet/Tgb3BFz1/h0rTQqEXzzfaYOrxb1LTCMcguoqRtE/J123JzFFhxBpcniGwk7tUVg8U1M X-Received: by 2002:a17:902:143:: with SMTP id 61-v6mr311013plb.171.1533230903269; Thu, 02 Aug 2018 10:28:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533230903; cv=none; d=google.com; s=arc-20160816; b=edwrU36/WqK9L6G8xzGippBHqXdQFv+H6xp7eQkBZLfdmOFPJDfocGFHBPeLnVmdoW 3Jsr6zwG+iNgpSDXtePNl5FY/PL7BKHwYSL1n95x5yUL/kqN2a510+ZBRSxpyCzJkjh2 2xmqGJuPTYRih46Be//ZlvGDwne4m0IQfE6F1sy/tT5DRldop9bOQ2DVu+Gjb0bG8QNs YLbczm95DROhqgqFt8BJ4WjPsWNQjp6dixgdQTUeN3NqU5I64CtXm6aAPLCVCEol//OF WUGyG+w/5qp8rIa+IhY5KNnySajHReblMYS0rnYGRkrcuAzVQ+OsnJW5iLw/9CdYYF04 DzSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=KwYD+47x7qvQTWci8ElMEZISbIN/EuE4/PSXuYpk0bc=; b=W2/ZUhHCRL6MKjG4ffRZdBfW1pd8tQ1niTLPZORSYqTL2dfE5FvOFYzJNqHFK7SGwB vRrtCEyU2/Wo8qwgDfRhY59Q9OpmxYxJB3yaW9TX/xE0bFvyLGvSaoQ9bKkcIX7m/x0x rHr+5FKX9xqyJMCnU8hN1ChE1tOYQVSDfq2+TlhE1ZQIUMZPxAC4+VEtCXpCyUsGrb3/ BohXCXA0yBuBrMeXc7q4+wdDRh637OMJMHip5zFASQYqWle+38zEUboIMO2Y4W+zvfo0 QoB73HX8OrVqyDSYNMJJlC806eUwkZEgOE+s25cmvENfI5OvgGFKmnT+MpYMycW4j4CV 36tw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=bkIb1cwp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a20-v6si2780025pgb.600.2018.08.02.10.28.08; Thu, 02 Aug 2018 10:28:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=bkIb1cwp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732120AbeHBTSU (ORCPT + 99 others); Thu, 2 Aug 2018 15:18:20 -0400 Received: from mail-qt0-f193.google.com ([209.85.216.193]:37225 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730217AbeHBTSU (ORCPT ); Thu, 2 Aug 2018 15:18:20 -0400 Received: by mail-qt0-f193.google.com with SMTP id n6-v6so3197461qtl.4 for ; Thu, 02 Aug 2018 10:26:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=KwYD+47x7qvQTWci8ElMEZISbIN/EuE4/PSXuYpk0bc=; b=bkIb1cwpW0Q8ZzP+wa4++ypiYKb/cXKBE+8rTAIqJqTG4ZuJb/3nDz+h/qW9LawGjl 3SI47Jh8SyLuCRCQCEloPzZQ1nnouG+F+OGc0NIaYY3z/PaxgouI16dULRmoOLkxIWMc BhOevJdWjnHCMZ01NApNJKUyvdUYZaNzuVIRxEUCm8yZ3NzvgY+ZDQo6y+0e4WiD5UBn wFo5iyVT2wPwoRhKxfRQrGiNmIaXAQiSOg7NlTNjqHoo+x/bOkgN6jwsUaVkPxjsCqHG 7FgD9Q7bujKAFDsoIt1ve/oXmcNv4dmeAF1CGeoKONK2UOGUo+S8JgyC95iCrZOAfvty wsxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=KwYD+47x7qvQTWci8ElMEZISbIN/EuE4/PSXuYpk0bc=; b=T0jmlNkr53Rfh10931+jTtPt5u1gi2jWYvKqwO3Dt0DdPL+GG6YwGRnnmK4ZkaIvUs TrInwI6kp7BEjYBER1WB0Kpp4uWzHCCrfkEMphHxkGAQ8phWrs2LTT2vywViRG2WzLwT 0CHTTnvETELLk6psIYSGHu2Pi81K9JoSz9ykieDZPlPZyLZmpWt8YIbPAdbMICEM7kZF mB5eKCadDx9jt6E9YG2mdumLJnYo6FJdk3M6rs7HXQKlCn2gYT87tF3rgVbP2QjH9UiH pdkCD4dSg/MEetjqyvFrRCYqEDKCZcp8cup74aiZyKyx40f4yOihDClc2yGdcoAQ34NK JFbg== X-Gm-Message-State: AOUpUlG951bf69gR+sSuI+xSIikw3OOgOoZr5yfQ3Baw8OTS/ELLmQFD sxuNxrjtiEe66E6TkrNQx5GOyo8d761cFIH4BkU= X-Received: by 2002:a0c:df14:: with SMTP id g20-v6mr375817qvl.183.1533230774809; Thu, 02 Aug 2018 10:26:14 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:aed:2a83:0:0:0:0:0 with HTTP; Thu, 2 Aug 2018 10:26:14 -0700 (PDT) In-Reply-To: References: <153320759911.18959.8842396230157677671.stgit@localhost.localdomain> From: Yang Shi Date: Thu, 2 Aug 2018 10:26:14 -0700 Message-ID: Subject: Re: [PATCH] mm: Move check for SHRINKER_NUMA_AWARE to do_shrink_slab() To: Shakeel Butt Cc: Kirill Tkhai , Andrew Morton , Vladimir Davydov , Michal Hocko , Andrey Ryabinin , Huang Ying , Tetsuo Handa , Matthew Wilcox , jbacik@fb.com, Linux MM , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 2, 2018 at 9:54 AM, Shakeel Butt wrote: > On Thu, Aug 2, 2018 at 9:47 AM Yang Shi wrote: >> >> On Thu, Aug 2, 2018 at 4:00 AM, Kirill Tkhai wrote: >> > In case of shrink_slab_memcg() we do not zero nid, when shrinker >> > is not numa-aware. This is not a real problem, since currently >> > all memcg-aware shrinkers are numa-aware too (we have two: >> >> Actually, this is not true. huge_zero_page_shrinker is NOT numa-aware. >> deferred_split_shrinker is numa-aware. >> > > But both huge_zero_page_shrinker and huge_zero_page_shrinker are not > memcg-aware shrinkers. I think Kirill is saying all memcg-aware > shrinkers are also numa-aware shrinkers. Aha, thanks for reminding. Yes, I missed that memcg-aware part. > > Shakeel