Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp89227imm; Thu, 2 Aug 2018 14:33:01 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeZDMeCeGsAJJXsPoVXb8nIUZ/AtjXEpcI0IURbwH2BxgfxRYNd4a1MuCUEk+T8kodAeHTA X-Received: by 2002:a63:5964:: with SMTP id j36-v6mr1086846pgm.222.1533245581343; Thu, 02 Aug 2018 14:33:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533245581; cv=none; d=google.com; s=arc-20160816; b=fKxst+fOgPx8zOcdyzj4FvP6jv60NdOjAtvwHnF62DxTDprR5ZHLcAeGDGRu+rfxfV Bf4DrJp5HywtunZ76o9eJ0/gYi/e+E4zhGHqPUlPpev1OXdDy1pl9ltUxNT1VxOWOdj7 WaVWvMxim6UOhxhIeWdduLWtBgSmvGAPdu59RUFzsB0r+Tic/KKyBrDtQ724jssANaeY Z/amrg/qWnhePl0V2Cr6hSSwHQXAypVx/MCuVQ+kdJznO6cF6EmZAluzAJyB/YiZxqxm 30FGQx9Ny8qyuYM8C2aliILtRF8pu/NYOHEb6cU8w+q23X8NLLNNxOWJsK74A1zyjDHa UIPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=+oy7xt4EOZxLna0GRNMFqVzAPZjfYwD9K7nS7F5dpqk=; b=eiNhYRYFk2Zxzwom3w2KFc56Dnn6NxAEl2x7l6x1VO5c2BknQVkWc+jiG4hZX5L3Ni scnHU5UY/FlJoY0+Py6b63hgtGtgLhcow7OuhuOAr5WEufohucJCHkw0jD3mIQzsBfN1 Xl5g9/9xXQjha3ARVeAcngCAeGbKvN94eR0Qb8QRiL/QwsA+PrejK3Omoq3oOBax/c9O 2AhXD93cVluyqofFnV2WUx0G/Yg9Rt1lNjwtA1Z3AKV5iMEPo9Vaoon6TvZH4euJyySR 6nnCcTqaLQ4L8TibneBTlhhAFQtkSI8+F/y5w7eJyIrWSeqMHMy4eZnfYOvWX+Cs2rTo Hb4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=tQX00zST; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t6-v6si2069797plq.268.2018.08.02.14.32.46; Thu, 02 Aug 2018 14:33:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=tQX00zST; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731977AbeHBXYx (ORCPT + 99 others); Thu, 2 Aug 2018 19:24:53 -0400 Received: from mail-pl0-f67.google.com ([209.85.160.67]:46712 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727193AbeHBXYx (ORCPT ); Thu, 2 Aug 2018 19:24:53 -0400 Received: by mail-pl0-f67.google.com with SMTP id t17-v6so1582182ply.13 for ; Thu, 02 Aug 2018 14:31:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+oy7xt4EOZxLna0GRNMFqVzAPZjfYwD9K7nS7F5dpqk=; b=tQX00zSTzD48AX8CXKkiFdulNAa0YbcxDhXBABV8e9jzhiOLm3TrSnpuUsC39bz2Ue jK2K0s8hLi25AIN6i8ii5J0Lnk88mRSvQkdpWJns9wAUfPRJLjFrP9w3zkJs/Gu3pPYf 2+8ohmVQZXKgEKXv/hH04QpQitxq7wXdnLqAQchxeT0WLFBBaUNDP/htnB8X4zX62vMH FH+MA15lWq+50acBsn17glnqecdSzd7SJdbFE4VxQPz+KqLqJ+MKizNCNZDQn0o9etmD 0YJUwl92BMdEuaALBIx5zieqYY+dFJCrkxlb50nEh4jI73H3UMfNaXFit3GkJXDSMcm+ +9fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+oy7xt4EOZxLna0GRNMFqVzAPZjfYwD9K7nS7F5dpqk=; b=Rc1B8rAQRc+zJp14CrF+W+Mg/zmItZtMJ8/mXuZMg1fIBBFKC6fppgc7Vv10ihOdSG onUQXlG0iKzDvJo5lYYPLr40tXTMYe2FchqLF6eEYqh6sGRD0caNkxd8HNkxG6wwEHdO ID2jbbRc+LT9VW9sopP8GlTG6GZZJdp1F6oUy/FXJ/p4Cn5OvXbtvG+fDBbSZS7W8VuI 4kScZjnCGfMTP4k/Db3FUFtSnGoVg7IbjL2ZPbRmcW2Kde/HrHg1cGpkqEKohQqUTC5A fqWTwnM6Kbj2pyGfLtR9PdPHYtOK3shGHphSaD951EenpdY2yZMBlbOXly0jX+zITK6R U79A== X-Gm-Message-State: AOUpUlE/wxRdY8knH2wkvhXaFHUNAyBbJHw684h4xT0oYAKudB/O2iQB RkPlOrzBc6lV1/4I9w7Xi2uiB2aOyOY= X-Received: by 2002:a17:902:8481:: with SMTP id c1-v6mr966817plo.177.1533245514619; Thu, 02 Aug 2018 14:31:54 -0700 (PDT) Received: from [192.168.1.212] (107.191.0.158.static.utbb.net. [107.191.0.158]) by smtp.gmail.com with ESMTPSA id k64-v6sm6065219pfc.160.2018.08.02.14.31.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 Aug 2018 14:31:53 -0700 (PDT) Subject: Re: [PATCH] block/compat_ioctl: fix range check in BLKGETSIZE To: Khazhismel Kumykov Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180406222350.174104-1-khazhy@google.com> From: Jens Axboe Message-ID: Date: Thu, 2 Aug 2018 15:31:52 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20180406222350.174104-1-khazhy@google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/6/18 4:23 PM, Khazhismel Kumykov wrote: > kernel ulong and compat_ulong_t may not be same width. Use type directly > to eliminate mismatches. > > This would result in truncation rather than EFBIG for 32bit mode for > large disks. Sorry for not getting to this. Applied, thanks. -- Jens Axboe