Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1533223376-10130-1-git-send-email-zong@andestech.com> <27367ec8-fc26-c678-1883-299a084a5328@wdc.com>
In-Reply-To: <27367ec8-fc26-c678-1883-299a084a5328@wdc.com>
From:   Zong Li <zongbox@gmail.com>
Date:   Fri, 3 Aug 2018 08:27:57 +0800
Message-ID: <CA+ZOyaiyaVqgba-pLABJgZHVTep8LXiiLQnT+dtCppdvJy36Zw@mail.gmail.com>
Subject: Re: [PATCH] RISC-V: Add preprocessor directives for boot_sec_cpu
To:     atish.patra@wdc.com
Cc:     Zong Li <zong@andestech.com>, Palmer Dabbelt <palmer@sifive.com>,
        aou@eecs.berkeley.edu, hch@infradead.org,
        linux-riscv@lists.infradead.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        greentime@andestech.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Atish Patra <atish.patra@wdc.com> =E6=96=BC 2018=E5=B9=B48=E6=9C=883=E6=97=
=A5 =E9=80=B1=E4=BA=94 =E4=B8=8A=E5=8D=882:14=E5=AF=AB=E9=81=93=EF=BC=9A
>
> On 8/2/18 8:23 AM, Zong Li wrote:
> > The boot_sec_cpu is for hutplug CPU on SMP system. It should
> > be conditional compiling. Otherwise, it causes undefined reference
> > to `smp_callin' when compiling uniprocessor kernel.
> >
> > Signed-off-by: Zong Li <zong@andestech.com>
> > ---
> >   arch/riscv/kernel/head.S | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/riscv/kernel/head.S b/arch/riscv/kernel/head.S
> > index 11066d5..9b6f601 100644
> > --- a/arch/riscv/kernel/head.S
> > +++ b/arch/riscv/kernel/head.S
> > @@ -154,6 +154,7 @@ END(_start)
> >   .section .text
> >   .global boot_sec_cpu
> >
> > +#ifdef CONFIG_HOTPLUG_CPU
> >   boot_sec_cpu:
> >       /* clear all pending flags */
> >       csrw sip, zero
> > @@ -162,6 +163,7 @@ boot_sec_cpu:
> >       fence
> >
> >       tail smp_callin
> > +#endif
> >
> >   __PAGE_ALIGNED_BSS
> >       /* Empty zero page */
> >
>
> Thanks for the fix. If you don't mind, I would like to merge it on top
> of my cpu hotplug patch and resubmit together to avoid confusion.
>
OK, just take it:)