Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp286626imm; Thu, 2 Aug 2018 19:11:16 -0700 (PDT) X-Google-Smtp-Source: AAOMgpd6Uiw77ssmTtwTVVt0RzG34g9v1xwx9Yk0j+Gr3AbNWm44mM59iyhbqyzR9oLZ73Q1Jsns X-Received: by 2002:a62:d24a:: with SMTP id c71-v6mr2135863pfg.242.1533262276787; Thu, 02 Aug 2018 19:11:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533262276; cv=none; d=google.com; s=arc-20160816; b=VFRKGpk1IQtV9tfCPaXHxNrCuQjXwf9t23O6loKtXFbX3X9IwN9gBtB9Fu80A2wgIm sfBJVQwf41TfNSbxUMsTKTMcTHvFdAQ5e03m4VChaExWDN/at/Mry7YNbC+U84kbMTx9 XpKpVX57KyqNXFRtw9D5w6NaH9XfZX2m8icC3qpRnOAeevQWluT9SErBhsz/m7fbOmwo N86jEobyqc9I5DA3jTz6IJwjv5Im5vdxtTwjgPUTYYDops1iU6lpLIAUFEfNPg6ftO7R 0ebcJSvcKOeRkE85jMxUlTKCvav05ZaSvkkQNh6df+d7IK4L6EoD2PMPgL1mSOFuMgvC m3Cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=QVT3IgxGdHfYTkh4j1hKy5lw7DFTGPJ7yv5Bk7FLvVE=; b=aVJ+HxX2RNf09QZEkrvD1EIuKtK++Qj4bPpis1gbkDyAu8kkXZSyZpi+0oplmT/KFT 0MHsDpEiNW2EhkkrOXiv+Wvtj5Oh11hc2efo6KGbIETM1RLdbC586IUZ6LQCHw3GtVPn s5CPoFKw+/cuFaIhlVZIOuVLGdjn5tNOZFbgWTVzsNN+73ftOhpM77qgfVysQhVS4qU/ 8wmX/Fx35A07wOiwbZaq7c3faYe1Ix98/veuRiIystAjHMGnbRKXUsSx7DBSQMMeoFin /8C+lEmBfl0B6pLWmWv8sECFZrdVCk3Ii9AQGQo+1sTrTqAhriSx/w0X978hEvGfDLwc o05g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u90-v6si3625165pfk.82.2018.08.02.19.11.01; Thu, 02 Aug 2018 19:11:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726489AbeHCEED (ORCPT + 99 others); Fri, 3 Aug 2018 00:04:03 -0400 Received: from nautica.notk.org ([91.121.71.147]:47094 "EHLO nautica.notk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725736AbeHCEED (ORCPT ); Fri, 3 Aug 2018 00:04:03 -0400 Received: by nautica.notk.org (Postfix, from userid 1001) id 59211C01A; Fri, 3 Aug 2018 04:10:06 +0200 (CEST) Date: Fri, 3 Aug 2018 04:09:51 +0200 From: Dominique Martinet To: piaojun Cc: Linux Kernel Mailing List , v9fs-developer@lists.sourceforge.net Subject: Re: [V9fs-developer] [PATCH v2] net/9p/trans_virtio.c: add null terminal for mount tag Message-ID: <20180803020951.GA16958@nautica> References: <5B6262F4.9080601@huawei.com> <20180802015439.GA27403@nautica> <5B62658A.3010605@huawei.com> <20180802152339.194c2820@bahia.lan> <5B63B3CE.3040601@huawei.com> <20180803020608.GA15635@nautica> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180803020608.GA15635@nautica> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dominique Martinet wrote on Fri, Aug 03, 2018: > (the code is currently not safe if it returns an error, I'm sending > another mail about it right after this one as we already have a partial > fix) I take that one back, ksys_mount() does check for error properly so just the null checks we have in Tomas' patch[1] are enough ; sorry for the double-mail [1] http://lkml.kernel.org/r/20180727110558.5479-1-tomasbortoli@gmail.com -- Dominique