Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp48226imm; Thu, 2 Aug 2018 22:40:54 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcWsM3zeWkajmtovETp1vq1zglOxt4HlY+fxOjJ/n/IIshjztoFG/mOoVMSbs9m8lPWB9U0 X-Received: by 2002:a62:15c8:: with SMTP id 191-v6mr2747563pfv.194.1533274854163; Thu, 02 Aug 2018 22:40:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533274854; cv=none; d=google.com; s=arc-20160816; b=KUGD7gnT71Uqwf0MEOZL8bcV9qciZDeB/t8u20T2pi259qQsYBDjWPWpM+7pgsbVsS bChOD8dwN3M9IA2IXZqVyPtuB3vzYAJw3js/w4AhCwcqcImgpNPTWY7HCNx5UkPz+3mu kHSXmEI3dKYwo07UeLyyx1YH1JaSj3fZ9uubDXEs/mMlKFomipAhUBrMyJaECCWSy4cT aRtzOlawRQkNuxo3ckj57EDjuL8CnOV+qdUuXpzuyb9/aVLFpOQrobcXWE9FUD94BMQR MXsUUDYJWRlNytV1JX/5P5a8IU4QNyVlgeWnRXRLXLdi3G1Ochb+Ro5fbX7XgmajRXer eUTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=Y4/bc0IHZezXKqcFmeN2CyQc34vsQsW5WASW67hWAzc=; b=JWDvnXVE6xk+XlELEfDdOuGZAspjfRztfj2sShDmZTMxJj2dNiy70V3AxcAdjWNoNn a+keSwf5rRqoSof5Msjoleq4l7KXYW4jxARHweRxSueHdFtjSzsm+Ny4VG04fGEg/kyE 84Dr0scqlTLaEemF+sGRfY6vd6oQWpU1/OMV3AfUOAO1ndil89aOrHMTEZ88kSzY7Owq rDyHvZ58bPPBCTYJ+PrLYZ3Uek5L1363YYf8MCVcV1YeKSQGI3Vkr1X8EQgsgoNvyPhF lOilBfPsP1IobMA6P8wIxBxT2MN4xn80sjXE2ekafo60SJgbQ9Ono4rO84NgWuqCGMgw fRfQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k26-v6si4447459pfk.199.2018.08.02.22.40.39; Thu, 02 Aug 2018 22:40:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727262AbeHCHe2 (ORCPT + 99 others); Fri, 3 Aug 2018 03:34:28 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:40564 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726829AbeHCHe2 (ORCPT ); Fri, 3 Aug 2018 03:34:28 -0400 Received: from localhost (D57E6652.static.ziggozakelijk.nl [213.126.102.82]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 4C71A3EE; Fri, 3 Aug 2018 05:39:51 +0000 (UTC) Date: Fri, 3 Aug 2018 07:39:48 +0200 From: Greg KH To: Zhang Ning Cc: kstewart@linuxfoundation.org, pombredanne@nexb.com, yamada.masahiro@socionext.com, markus@trippelsdorf.de, linux-kernel@vger.kernel.org, Ting Subject: Re: [PATCH] firmware: make sure builtin firmware is page alignment Message-ID: <20180803053948.GB1852@kroah.com> References: <20180803014521.21527-1-ning.a.zhang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180803014521.21527-1-ning.a.zhang@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 03, 2018 at 09:45:21AM +0800, Zhang Ning wrote: > when firmware is in filesystem, request_firmware will load it, > and copy it to vmalloc memory, that is page align memory. > > but when firmware is builtin, it is 8 bytes or 4 bytes alignment. > > make sure builtin firmware is page algnment, that can simplify algorithm > to handle firmware. How is it simplified? I don't see any such change like that here :(