Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp60654imm; Thu, 2 Aug 2018 22:57:54 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdmP+w/98b+PRTd9vGMbMKGxKAquChgSw7QyU3OLI6+sEVr7GIiBqVpjtem6Yhs4KO2sSHN X-Received: by 2002:a17:902:9a8a:: with SMTP id w10-v6mr2249453plp.14.1533275874656; Thu, 02 Aug 2018 22:57:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533275874; cv=none; d=google.com; s=arc-20160816; b=dtQN889ZwYIy1yRtKmHewPFzbAPtrormC8seHFoM7hosKLXJUeWiblVBpnJo+iWIgE Hgbvye3YBFYR/gd8JkqOApQoqu2Hf8hOMr8dZnty23MEjkKGVxifeiit3xziPhORtW/i xVhI+14aplvLghPjrXBn6mUrfhdwTyjbAFxpfePnijB/6o01IufFc9zcu+OCKn2ty7/Q aI7ffPRYHnlrOAD5OsJBvOTKf9HmrsqD6A3GrykCBpNBWPhWTAlnvoZT3431sZ3BzYIU rAkWkV3S2pjpJzO9FgXYANr9cA3jmIeCSUBH8jbfArL7LXDejF1BXXehQCU3WVm33HL7 cVfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=1tXSUBzf+jpY18neg/bD8DWbMKk1/Y0lyKU0hNKml1E=; b=PshP5fDa5vrWkQcWG3L1CorbDws+lr5Im0W1kj1WAvIPAWiCYBOgfuNgMtaal/opwM UM/MP6hfWbibngWJJ+eQ2jEhcFVldVz5D0dWNtp48NAPVKOGjt6eahcp2o5avCXSlvpN rCdT2VvUdSplYlR58WkE819PMXfbr3LXp1ILN0Dxc1OjXHlljmAaVbow4TR1kSZNzOCn 3g05rXwDWPlTxUzzl0PaCoFt+8Kj9eTdYTcRbfynpk6v5wAeQTXKpbAcRnFU2bUxoqtb MwMFbfRAsvfKBduNuv0tT4GxJIXdx1A0dnGIH18pt9QIm8F1G88uyiHuLOPQUoadOY7y h+Rw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a9-v6si3393704pgf.380.2018.08.02.22.57.37; Thu, 02 Aug 2018 22:57:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727532AbeHCHvX (ORCPT + 99 others); Fri, 3 Aug 2018 03:51:23 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:41578 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726799AbeHCHvX (ORCPT ); Fri, 3 Aug 2018 03:51:23 -0400 Received: from localhost (D57E6652.static.ziggozakelijk.nl [213.126.102.82]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id DBEE5927; Fri, 3 Aug 2018 05:56:42 +0000 (UTC) Date: Fri, 3 Aug 2018 07:56:40 +0200 From: Greg Kroah-Hartman To: Songjun Wu Cc: hua.ma@linux.intel.com, yixin.zhu@linux.intel.com, chuanhua.lei@linux.intel.com, qi-ming.wu@intel.com, linux-mips@linux-mips.org, linux-clk@vger.kernel.org, linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Jiri Slaby Subject: Re: [PATCH v2 14/18] serial: intel: Add CCF support Message-ID: <20180803055640.GA32226@kroah.com> References: <20180803030237.3366-1-songjun.wu@linux.intel.com> <20180803030237.3366-15-songjun.wu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180803030237.3366-15-songjun.wu@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 03, 2018 at 11:02:33AM +0800, Songjun Wu wrote: > Previous implementation uses platform-dependent API to get the clock. > Those functions are not available for other SoC which uses the same IP. > The CCF (Common Clock Framework) have an abstraction based APIs for > clock. In future, the platform specific code will be removed when the > legacy soc use CCF as well. > Change to use CCF APIs to get clock and rate. So that different SoCs > can use the same driver. > > Signed-off-by: Songjun Wu > --- > > Changes in v2: None > > drivers/tty/serial/lantiq.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/tty/serial/lantiq.c b/drivers/tty/serial/lantiq.c > index 36479d66fb7c..35518ab3a80d 100644 > --- a/drivers/tty/serial/lantiq.c > +++ b/drivers/tty/serial/lantiq.c > @@ -26,7 +26,9 @@ > #include > #include > > +#ifdef CONFIG_LANTIQ > #include > +#endif That is never how you do this in Linux, you know better. Please go and get this patchset reviewed and signed-off-by from other internal Intel kernel developers before resending it next time. It is their job to find and fix your basic errors like this, not ours. greg k-h