Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp116087imm; Fri, 3 Aug 2018 00:07:28 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdw+UBZLHXoPYXGAICVncuRJHucb7os/lD0fQlfHn9Uyf0wBENZe8FCLUB3KUUNjJqFYJKl X-Received: by 2002:a63:1a20:: with SMTP id a32-v6mr2480423pga.446.1533280048317; Fri, 03 Aug 2018 00:07:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533280048; cv=none; d=google.com; s=arc-20160816; b=Ylvf7S6AFqfqC7DQ/2G8VWNOiKie75KtJBfimpB3367XxzIkW/sIqO6FDu9tvHiHyw w/0dxqsTxTugw8J0w0YnYbjtSj4GsDXlE029TdDHU04GceH2xnDcuZnsCmE5dZApNcHl ikwCWSxTwDdgVcSqBtxLmx8EkR30r1qP/n3SVllkA0+VSvmLlXlwd6Xa/Rvm/DsaOLge TUXcslrLdT2XDqbab4IAAwq0rmJPp2WmIYO53z6HuktvzJkj99p9HOBYSFDL7wDJQaMC ZqqdEozHAY9C73EMzmk3gzG2aIA/4FJd0JvntPZLGai+QjHKij61PmDt3m3jdcRUI+KS KnlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:cc:references:to :subject:arc-authentication-results; bh=9wGpAQOUs6PJloSTx9VTOK1JQ8OQLGvdFqZHolgtTik=; b=x5mu8jwshaW6BkA3mcJx3ntObbCxR9LQSZx7WxkqXcmDhFRyfim5G1Ng/fifSbIR22 4MDV2OhhJFln6tPT5XUmcgbDH3CbKhYIOE79s5UGoJZmD3opkJTuDK839zcuHamgg8Kf 4BNmXPfX/Z+oEV4J0f8Qs3iel0nVSjXr+P2TAO8DNMJLAu02Jw0YrH+Ue8mTsWMnuJPf YcpTIsJkA+fcJ0jdTCAYE7k1SLWP0RohkLlwn8l8gQ4wgFlOtB7leY8tHwUn+NEKSx/T tbaRR+kaUmrA/fz+3kPvXMs6h8NeTziHcSxRcrv26lgDqe6f25WhEby5o7zO60T/CyCy FSIA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j10-v6si4438179pfc.335.2018.08.03.00.07.13; Fri, 03 Aug 2018 00:07:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729946AbeHCJAu (ORCPT + 99 others); Fri, 3 Aug 2018 05:00:50 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:10623 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728147AbeHCJAu (ORCPT ); Fri, 3 Aug 2018 05:00:50 -0400 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 5F6F641F9A202; Fri, 3 Aug 2018 15:05:54 +0800 (CST) Received: from [127.0.0.1] (10.57.77.74) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.399.0; Fri, 3 Aug 2018 15:05:46 +0800 Subject: Re: [PATCH] gpu/drm/hisilicon: Convert drm_atomic_helper_suspend/resume() To: Souptick Joarder , Zou Rongrong , , , , , "Sean Paul" References: <20180719160426.GA21958@jordon-HP-15-Notebook-PC> CC: , , "Ajit Linux" , Sabyasachi Gupta , Brajeswar Ghosh , Daniel Vetter From: xinliang Message-ID: <5B63FE39.4070402@hisilicon.com> Date: Fri, 3 Aug 2018 15:03:21 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.57.77.74] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018/8/2 17:57, Souptick Joarder wrote: > On Thu, Jul 26, 2018 at 1:37 PM, Souptick Joarder wrote: >> >On Thu, Jul 19, 2018 at 9:34 PM, Souptick Joarder wrote: >>> >>convert drm_atomic_helper_suspend/resume() to use >>> >>drm_mode_config_helper_suspend/resume(). >>> >> >>> >>Fixed one sparse warning by making hibmc_drm_interrupt >>> >>static. >>> >> >>> >>Signed-off-by: Souptick Joarder >>> >>Signed-off-by: Ajit Negi >>> >>--- >> > >> >Any comment on this patch ? > Any review comment for this patch ? Sorry for late reply. Looks good to me. Thanks. Reviewed-by: Xinliang Liu