Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp128989imm; Fri, 3 Aug 2018 00:24:25 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcCyhPHwCzWlV9eUyXoHeM6gPixlYm38YfkwLlfp8NuP+LAbhUxI9IuNMdk5YEFyOhjDjB2 X-Received: by 2002:a62:dc8f:: with SMTP id c15-v6mr3057510pfl.155.1533281065761; Fri, 03 Aug 2018 00:24:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533281065; cv=none; d=google.com; s=arc-20160816; b=yYrSRCgeQNBf5nBBsMsi0uYWCBYbo4SUacoMP9+bGlyiO0edS1ouru79Uh3LhE2is3 D83M/W3CB3ctN8KwPy1JDlGRT6/8SeQJHZoajMQoP1FpYi/uGJp8hsIS4NQ2HAtq5WZv y06K6ILTkX1d8k23EJ6wlI2WUTR+6nESmLpLDlJMKqnv8e1UFiD2Mes7+7mK2ZdWku0n UZX+4ZbFBScdOMh3nF33oJAfzrFYDJwix+UM/DBwQOoKwJu/91lWRk7J1G+f3TQ3HmEp f9WVujLD4iNe5EXHravZCrxGrI5/i/JLCClXxegcmcNeTHMr7vDiNLKLiIIIO8NPV4op n+/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter :arc-authentication-results; bh=+0LEdI0tbpncqLolsx8+88+h1o2BYz5/RWpFQWPdgbQ=; b=D7x+a3CSmf+zbJr4oVCSjl36th86az3UsweSuGwKxUWlZltJ/rlR/fN4coa1aJN1z4 78axFPleExDjqnXJA+wOj9KjuYjtcy6gQmB1W/s0cIGmDHowHYMLrDQXJQsJclQUynRU 614xhr4do988nN/B0FIysQTkt8C/psaGNvZng5RPucnZXUTPYVo1ZB1ygAfWTsNmxrWK Wwkhgdc9G/fcOg4DDKbnYwgHn2bKzjjGv1t39vLDU4/LbYQvirU007rPyQrJ0ew4lTU6 qLq1/pNifLPsktoClGF1GUEfCz2+MHxpl39/a3TASIq/YX7hYGQvJk7mj3Vm80ifVO5h Azqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@iluvatar.ai header.s=809B2F8E-810B-11E8-86FD-A0A654EEFFEB header.b="HcC2/Aqo"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=iluvatar.ai Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a1-v6si4351509pgg.326.2018.08.03.00.24.11; Fri, 03 Aug 2018 00:24:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@iluvatar.ai header.s=809B2F8E-810B-11E8-86FD-A0A654EEFFEB header.b="HcC2/Aqo"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=iluvatar.ai Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732806AbeHCJQv (ORCPT + 99 others); Fri, 3 Aug 2018 05:16:51 -0400 Received: from mail.iluvatar.ai ([58.213.90.100]:59484 "EHLO mail.iluvatar.ai" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729792AbeHCJQu (ORCPT ); Fri, 3 Aug 2018 05:16:50 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.iluvatar.ai (Postfix) with ESMTP id D4E12145043E7; Fri, 3 Aug 2018 15:25:06 +0800 (CST) Received: from mail.iluvatar.ai ([127.0.0.1]) by localhost (mail.iluvatar.ai [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id qbi4HePeErs1; Fri, 3 Aug 2018 15:25:06 +0800 (CST) Received: from localhost (localhost [127.0.0.1]) by mail.iluvatar.ai (Postfix) with ESMTP id 83230145043E5; Fri, 3 Aug 2018 15:25:06 +0800 (CST) DKIM-Filter: OpenDKIM Filter v2.9.2 mail.iluvatar.ai 83230145043E5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iluvatar.ai; s=809B2F8E-810B-11E8-86FD-A0A654EEFFEB; t=1533281106; bh=+0LEdI0tbpncqLolsx8+88+h1o2BYz5/RWpFQWPdgbQ=; h=From:To:Subject:Date:Message-Id; b=HcC2/AqoeB8Ev3PQmhVaekRq8vZM23ITh/7Jas7xLU2S1xwK9HRtrgmGqcGQIPg2k dbNGaigiU+uUXWf4eh6hakCqEHM0BbkELp6gH0X7hcOnyj6UT+ZGLzS5Vz+yDkt/Qh zZAl+p/ZLRJlzmkWlaZkxtpXs42HopmvQ7WUSenA= X-Virus-Scanned: amavisd-new at iluvatar.ai Received: from mail.iluvatar.ai ([127.0.0.1]) by localhost (mail.iluvatar.ai [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Za_VUvQ5aMC0; Fri, 3 Aug 2018 15:25:06 +0800 (CST) Received: from localhost.localdomain (unknown [180.166.124.10]) by mail.iluvatar.ai (Postfix) with ESMTPSA id A2667107081E4; Fri, 3 Aug 2018 15:25:05 +0800 (CST) From: Huang Shijie To: vkoul@kernel.org Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, dave.jiang@intel.com, radhey.shyam.pandey@xilinx.com, appana.durga.rao@xilinx.com, jmkrzyszt@gmail.com, gomonovych@gmail.com, peter.ujfalusi@ti.com, keescook@chromium.org, horms+renesas@verge.net.au, geert+renesas@glider.be, shawnguo@kernel.org, baoyou.xie@linaro.org, michal.simek@xilinx.com, baohua@kernel.org, ludovic.desroches@microchip.com, linus.walleij@linaro.org, david.brown@linaro.org, Huang Shijie Subject: [PATCH 20/46] dmaengine: sirf-dma: use dmaenginem_async_device_register to simplify the code Date: Fri, 3 Aug 2018 15:19:50 +0800 Message-Id: <20180803072016.21544-21-sjhuang@iluvatar.ai> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180803072016.21544-1-sjhuang@iluvatar.ai> References: <20180803072016.21544-1-sjhuang@iluvatar.ai> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use dmaenginem_async_device_register to simplify the code: remove dma_async_device_unregister. remove label unreg_dma_dev Signed-off-by: Huang Shijie --- drivers/dma/sirf-dma.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/dma/sirf-dma.c b/drivers/dma/sirf-dma.c index a0733ac3edb1..de19880d4254 100644 --- a/drivers/dma/sirf-dma.c +++ b/drivers/dma/sirf-dma.c @@ -944,7 +944,7 @@ static int sirfsoc_dma_probe(struct platform_device *op) /* Register DMA engine */ dev_set_drvdata(dev, sdma); - ret = dma_async_device_register(dma); + ret = dmaenginem_async_device_register(dma); if (ret) goto free_irq; @@ -952,7 +952,7 @@ static int sirfsoc_dma_probe(struct platform_device *op) ret = of_dma_controller_register(dn, of_dma_sirfsoc_xlate, sdma); if (ret) { dev_err(dev, "failed to register DMA controller\n"); - goto unreg_dma_dev; + goto free_irq; } pm_runtime_enable(&op->dev); @@ -960,8 +960,6 @@ static int sirfsoc_dma_probe(struct platform_device *op) return 0; -unreg_dma_dev: - dma_async_device_unregister(dma); free_irq: free_irq(sdma->irq, sdma); irq_dispose: @@ -975,7 +973,6 @@ static int sirfsoc_dma_remove(struct platform_device *op) struct sirfsoc_dma *sdma = dev_get_drvdata(dev); of_dma_controller_free(op->dev.of_node); - dma_async_device_unregister(&sdma->dma); free_irq(sdma->irq, sdma); tasklet_kill(&sdma->tasklet); irq_dispose_mapping(sdma->irq); -- 2.17.1