Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp129844imm; Fri, 3 Aug 2018 00:25:31 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdyXJHcPBIDukaroZOiSwOiEjPWALOujkVy/dUBUZXg09qNXHot+hfGj4BpCSrZH7d+QPlA X-Received: by 2002:a17:902:9a06:: with SMTP id v6-v6mr2491096plp.316.1533281131128; Fri, 03 Aug 2018 00:25:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533281131; cv=none; d=google.com; s=arc-20160816; b=qWUVtX1yqGCYcYY3joaPDa75gAMVu4Dq5klWRfrT3MROczugGt7Un++L/0x47n621L iMgPTVeALgfUFhtiGIRufi+BoIrbgt6ZvLNOLB3y30tXYIg0p1tXZOk6kxfX+4xqKA69 nrRLFyVIkVMlayrJ3Ow0LzQ+moe9/vz6jVmeSy8poNYk3F+O71wl42LWAgc26uQ5LWD5 HGHc1RYHmXYEMhyedY6wHhCAt/qynyD+6mHZohqVtjbfIBVt6k3jqtUBjpRDH1wlGEjH BhXPblCvPOPi5Qrnnj54nlbYf9n7PruOCDk40AJY8BehBzYEoyxU7DKofcgOth/my81p /uwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter :arc-authentication-results; bh=MIDct06K7D3I+nNx9snOLVORGB+I4sXowbtdn7FRzIA=; b=QFpxjgJeAWfrgacZDigHinQiSiPLiJvSbSWJWh2tCnzuWUcPmzRTYk163ozoEH8dQ4 QdWo2BQNs7kPucxwz32DXJyfUFOTAPLJsykKUmDiKyevEihoXVW+o/NNF6sdGxuTLj0/ v1ZebbEhGvk1xzgkzEu8grdilk67cd7qCZUafmhdspHB/5NPhfCsiroNjb9Lo44tAmP4 eGjpKRLpcnRwpL/xGMxPf3Df14tvQNqN1XFVJBii/340/YH6PSQ2f9cyopL8/Iq6Pj6J ycGoTn19MznQPQfYC6Gql6ISqhlebAePU8NRa+/izCUkLAHKecIX9QyrvvGSQNpixBwp arOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@iluvatar.ai header.s=809B2F8E-810B-11E8-86FD-A0A654EEFFEB header.b="NDA6ue//"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=iluvatar.ai Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y14-v6si4202181pgg.76.2018.08.03.00.25.16; Fri, 03 Aug 2018 00:25:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@iluvatar.ai header.s=809B2F8E-810B-11E8-86FD-A0A654EEFFEB header.b="NDA6ue//"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=iluvatar.ai Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732732AbeHCJQr (ORCPT + 99 others); Fri, 3 Aug 2018 05:16:47 -0400 Received: from mail.iluvatar.ai ([58.213.90.100]:58213 "EHLO mail.iluvatar.ai" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729792AbeHCJQp (ORCPT ); Fri, 3 Aug 2018 05:16:45 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.iluvatar.ai (Postfix) with ESMTP id B3259145043FF; Fri, 3 Aug 2018 15:25:09 +0800 (CST) Received: from mail.iluvatar.ai ([127.0.0.1]) by localhost (mail.iluvatar.ai [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id ZihNdxV5xzk7; Fri, 3 Aug 2018 15:25:08 +0800 (CST) Received: from localhost (localhost [127.0.0.1]) by mail.iluvatar.ai (Postfix) with ESMTP id C8FE4145043F5; Fri, 3 Aug 2018 15:25:08 +0800 (CST) DKIM-Filter: OpenDKIM Filter v2.9.2 mail.iluvatar.ai C8FE4145043F5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iluvatar.ai; s=809B2F8E-810B-11E8-86FD-A0A654EEFFEB; t=1533281108; bh=MIDct06K7D3I+nNx9snOLVORGB+I4sXowbtdn7FRzIA=; h=From:To:Subject:Date:Message-Id; b=NDA6ue//yU8oQGHglIQILXocid84co2jfpNOq6v5Mxs+al8P+LnQamlkEe1QhxQmr z9FC+ClIMykJA02yGMqAQwft0hfAQtx0mzuN+gEby+K8aeGTV0Zm/jrWjqxbUoGfuz 2ZyPD0MyifvF4Vw3wAxzpiThSiwgk2oahI9Ln00c= X-Virus-Scanned: amavisd-new at iluvatar.ai Received: from mail.iluvatar.ai ([127.0.0.1]) by localhost (mail.iluvatar.ai [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 0Qbw3UhO52Md; Fri, 3 Aug 2018 15:25:08 +0800 (CST) Received: from localhost.localdomain (unknown [180.166.124.10]) by mail.iluvatar.ai (Postfix) with ESMTPSA id 64575145043E5; Fri, 3 Aug 2018 15:25:08 +0800 (CST) From: Huang Shijie To: vkoul@kernel.org Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, dave.jiang@intel.com, radhey.shyam.pandey@xilinx.com, appana.durga.rao@xilinx.com, jmkrzyszt@gmail.com, gomonovych@gmail.com, peter.ujfalusi@ti.com, keescook@chromium.org, horms+renesas@verge.net.au, geert+renesas@glider.be, shawnguo@kernel.org, baoyou.xie@linaro.org, michal.simek@xilinx.com, baohua@kernel.org, ludovic.desroches@microchip.com, linus.walleij@linaro.org, david.brown@linaro.org, Huang Shijie Subject: [PATCH 24/46] dmaengine: nbpfaxi: use dmaenginem_async_device_register to simplify the code Date: Fri, 3 Aug 2018 15:19:54 +0800 Message-Id: <20180803072016.21544-25-sjhuang@iluvatar.ai> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180803072016.21544-1-sjhuang@iluvatar.ai> References: <20180803072016.21544-1-sjhuang@iluvatar.ai> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use dmaenginem_async_device_register to simplify the code: remove dma_async_device_unregister. remove label e_dma_dev_unreg Signed-off-by: Huang Shijie --- drivers/dma/nbpfaxi.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/dma/nbpfaxi.c b/drivers/dma/nbpfaxi.c index 8c7b2e8703da..def82e77f321 100644 --- a/drivers/dma/nbpfaxi.c +++ b/drivers/dma/nbpfaxi.c @@ -1437,18 +1437,16 @@ static int nbpf_probe(struct platform_device *pdev) nbpf_configure(nbpf); - ret = dma_async_device_register(dma_dev); + ret = dmaenginem_async_device_register(dma_dev); if (ret < 0) goto e_clk_off; ret = of_dma_controller_register(np, nbpf_of_xlate, nbpf); if (ret < 0) - goto e_dma_dev_unreg; + goto e_clk_off; return 0; -e_dma_dev_unreg: - dma_async_device_unregister(dma_dev); e_clk_off: clk_disable_unprepare(nbpf->clk); @@ -1471,7 +1469,6 @@ static int nbpf_remove(struct platform_device *pdev) } of_dma_controller_free(pdev->dev.of_node); - dma_async_device_unregister(&nbpf->dma_dev); clk_disable_unprepare(nbpf->clk); return 0; -- 2.17.1