Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <CABPqkBT0P=GKNb6ypjaPxe4dEwShHk37mdrX0RtodMm44gaE+Q@mail.gmail.com>
 <20180719082539.GB18667@krava> <20180731092128.GA17617@krava>
In-Reply-To: <20180731092128.GA17617@krava>
From:   Stephane Eranian <eranian@google.com>
Date:   Fri, 3 Aug 2018 00:28:16 -0700
Message-ID: <CABPqkBQOWGUsTOXP1CjVxSDtquSGrxaiSqK1ZgJcW0jfzwENsg@mail.gmail.com>
Subject: Re: [RFC] perf annotate: option to report global percentage
To:     Jiri Olsa <jolsa@redhat.com>
Cc:     Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Jiri,
On Tue, Jul 31, 2018 at 2:21 AM Jiri Olsa <jolsa@redhat.com> wrote:
>
> On Thu, Jul 19, 2018 at 10:25:39AM +0200, Jiri Olsa wrote:
> > On Wed, Jul 18, 2018 at 02:55:14PM -0700, Stephane Eranian wrote:
> > > Hi Jiri,
> > >
> > > As far as I know, once you go into annotate mode, via perf report TUI
> > > mode, the percentage you see per instruction is relative to the
> > > function. I would like the option to display the total percentage,
> > > i..e, the importance of the instruction for the entire run. Right now,
> > > if I want that, I need to do function_percentage * insn_percentage by
> > > hand. This is not convenient. Having a key toggle would be very
> > > useful, worst case a cmdline option.
> > >
> > > What do you think?
> >
> > hi,
> > that should be simple to add, we already have the 'F' in the
> > main browser window to toggle among full/filtered scale
> >
> > I'll try to add something similar for annotation window
>
> sry for delay, I was out last week
>
> I put something together and pushed it in here:
>   git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
>   perf/annotate_percent
>
> there's the 'p' key to switch between local and global period
> I haven't added any command line option for stdio yet
>
> I'll have more testing and post later but any feedback
> now would be great
>
Tested your code on a few examples and it seems to work well. Looks nice!
Thanks.
PS: I'll have more small requests coming based on user feedback and my
personal experience.

>
> thanks,
> jirka