Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp145460imm; Fri, 3 Aug 2018 00:46:26 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcTpoz19VHPTA2NOMi+IeTQxruKvJxKv3I46hn7b0lrU+1aZ9oulyYybJbIKsYv87WOOdPa X-Received: by 2002:a62:3545:: with SMTP id c66-v6mr3152392pfa.63.1533282386880; Fri, 03 Aug 2018 00:46:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533282386; cv=none; d=google.com; s=arc-20160816; b=ObU1TY1iO6DTjZqLQ0TIP1YC6xExt+xO97D9Eq1hZdKkJYqtVBRWsaQHRNuiWRgHd2 5ZrUkk7kD8K1z174nJhjop28M0sp8rtuPETpD89NIqSvIdLogWp9AjqcFitcUMCz+pSF UaE3nm/d5DmGXpqML0cCJLb5Yigg5M8sjSVa/OrofTWTGqxDXnLrpdLX63X6iXlOCVRA y6HPTJ5zWCMKcDo35NmjwACc7Bv+gkY5HVJVqdKRnwlTk9+kkydW44g2W0JkJ5NAdZTT hoXCwTrYVurKLXRXVv0pGKSs1lOOqSuGvGwAdS5ExptUAgpfclxppqSkJ5M7GaOplHW7 pHPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter :arc-authentication-results; bh=vcDaDJOSDa3hN9eZg/GV29baml3jT4+orzxm4WstkYk=; b=lDy6eBlhhRlDW29FEMdwiuIejBtE3LsVE4OQliWjLudPTeDGBKXNjvbK2Ihg7TuO0q IH6iQjqikqZrxVkxTDl6cKVLbcRpP7osIPUtoHMEVkUnycNIlsswap8sbpn1mE5xHI9c xt2CBkhfLuYPOMeivCJDjTM7hdTMWV41pSGAHeUgdmz+Pnk5vyR7+AQBJJiq9spj0vp6 /l0J7/32ObAwhRjh8uQhYOLprhU2xXrJ6my3oG0HLuItTbLkVhTCRoAMLYf3tcwZgnDc 91NZsUODtGhuwrrk57ICd97JhQSN48YRdE5YYzQwhS0rCqSSAuZlaU/QUCnppChRTQUq 6Xkg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@iluvatar.ai header.s=809B2F8E-810B-11E8-86FD-A0A654EEFFEB header.b=Ehjo6eMU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=iluvatar.ai Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h2-v6si4200057pgk.330.2018.08.03.00.46.12; Fri, 03 Aug 2018 00:46:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@iluvatar.ai header.s=809B2F8E-810B-11E8-86FD-A0A654EEFFEB header.b=Ehjo6eMU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=iluvatar.ai Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733007AbeHCJTt (ORCPT + 99 others); Fri, 3 Aug 2018 05:19:49 -0400 Received: from mail.iluvatar.ai ([58.213.90.100]:58124 "EHLO mail.iluvatar.ai" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732459AbeHCJQe (ORCPT ); Fri, 3 Aug 2018 05:16:34 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.iluvatar.ai (Postfix) with ESMTP id 415A0145043E0; Fri, 3 Aug 2018 15:25:06 +0800 (CST) Received: from mail.iluvatar.ai ([127.0.0.1]) by localhost (mail.iluvatar.ai [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id avnzggResGyn; Fri, 3 Aug 2018 15:25:06 +0800 (CST) Received: from localhost (localhost [127.0.0.1]) by mail.iluvatar.ai (Postfix) with ESMTP id D38CC140B5B36; Fri, 3 Aug 2018 15:25:05 +0800 (CST) DKIM-Filter: OpenDKIM Filter v2.9.2 mail.iluvatar.ai D38CC140B5B36 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iluvatar.ai; s=809B2F8E-810B-11E8-86FD-A0A654EEFFEB; t=1533281105; bh=vcDaDJOSDa3hN9eZg/GV29baml3jT4+orzxm4WstkYk=; h=From:To:Subject:Date:Message-Id; b=Ehjo6eMUKCCZ06GV4uFkLaAglPxfsqRoTr9vSVEuu4EXxnHLRmdAPef5KCr96v9o3 kTt99bkwu9jfsbmL+CtGUqZuwRb6zrQvTSKOtBUMhToYQW3PX5td1jmkA2Y63g5TfT 1fbGBMkMbXUF/Oo7K+sQGV87DnNdljAByVDuK/EA= X-Virus-Scanned: amavisd-new at iluvatar.ai Received: from mail.iluvatar.ai ([127.0.0.1]) by localhost (mail.iluvatar.ai [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id owEe3doObIDK; Fri, 3 Aug 2018 15:25:05 +0800 (CST) Received: from localhost.localdomain (unknown [180.166.124.10]) by mail.iluvatar.ai (Postfix) with ESMTPSA id 167EA107081ED; Fri, 3 Aug 2018 15:25:05 +0800 (CST) From: Huang Shijie To: vkoul@kernel.org Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, dave.jiang@intel.com, radhey.shyam.pandey@xilinx.com, appana.durga.rao@xilinx.com, jmkrzyszt@gmail.com, gomonovych@gmail.com, peter.ujfalusi@ti.com, keescook@chromium.org, horms+renesas@verge.net.au, geert+renesas@glider.be, shawnguo@kernel.org, baoyou.xie@linaro.org, michal.simek@xilinx.com, baohua@kernel.org, ludovic.desroches@microchip.com, linus.walleij@linaro.org, david.brown@linaro.org, Huang Shijie Subject: [PATCH 19/46] dmaengine: sprd-dma: use dmaenginem_async_device_register to simplify the code Date: Fri, 3 Aug 2018 15:19:49 +0800 Message-Id: <20180803072016.21544-20-sjhuang@iluvatar.ai> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180803072016.21544-1-sjhuang@iluvatar.ai> References: <20180803072016.21544-1-sjhuang@iluvatar.ai> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use dmaenginem_async_device_register to simplify the code: remove dma_async_device_unregister. remove label err_of_register Signed-off-by: Huang Shijie --- drivers/dma/sprd-dma.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c index 55df0d41355b..d06459d1f96f 100644 --- a/drivers/dma/sprd-dma.c +++ b/drivers/dma/sprd-dma.c @@ -943,7 +943,7 @@ static int sprd_dma_probe(struct platform_device *pdev) if (ret < 0) goto err_rpm; - ret = dma_async_device_register(&sdev->dma_dev); + ret = dmaenginem_async_device_register(&sdev->dma_dev); if (ret < 0) { dev_err(&pdev->dev, "register dma device failed:%d\n", ret); goto err_register; @@ -953,13 +953,11 @@ static int sprd_dma_probe(struct platform_device *pdev) ret = of_dma_controller_register(np, of_dma_simple_xlate, &sprd_dma_info); if (ret) - goto err_of_register; + goto err_register; pm_runtime_put(&pdev->dev); return 0; -err_of_register: - dma_async_device_unregister(&sdev->dma_dev); err_register: pm_runtime_put_noidle(&pdev->dev); pm_runtime_disable(&pdev->dev); @@ -989,7 +987,6 @@ static int sprd_dma_remove(struct platform_device *pdev) } of_dma_controller_free(pdev->dev.of_node); - dma_async_device_unregister(&sdev->dma_dev); sprd_dma_disable(sdev); pm_runtime_put_noidle(&pdev->dev); -- 2.17.1