Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 3 Aug 2018 15:54:35 +0800
From:   Huang Shijie <sjhuang@iluvatar.ai>
To:     Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc:     vkoul@kernel.org, dmaengine@vger.kernel.org,
        linux-kernel@vger.kernel.org, dave.jiang@intel.com,
        radhey.shyam.pandey@xilinx.com, appana.durga.rao@xilinx.com,
        jmkrzyszt@gmail.com, gomonovych@gmail.com, keescook@chromium.org,
        horms+renesas@verge.net.au, geert+renesas@glider.be,
        shawnguo@kernel.org, baoyou.xie@linaro.org,
        michal.simek@xilinx.com, baohua@kernel.org,
        ludovic.desroches@microchip.com, linus.walleij@linaro.org,
        david.brown@linaro.org
Subject: Re: [PATCH 08/46] dmaengine: edma: use
 dmaenginem_async_device_register to simplify the code
Message-ID: <20180803075434.GB29473@hsj-Precision-5520>
References: <20180803072016.21544-1-sjhuang@iluvatar.ai>
 <20180803072016.21544-9-sjhuang@iluvatar.ai>
 <c47c117b-dfc7-12e7-7769-15dcf6716d32@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c47c117b-dfc7-12e7-7769-15dcf6716d32@ti.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Aug 03, 2018 at 10:50:13AM +0300, Peter Ujfalusi wrote:
> 
> 
> On 2018-08-03 10:19, Huang Shijie wrote:
> > Use dmaenginem_async_device_register to simplify the code:
> >    remove dma_async_device_unregister
> > 
> > Signed-off-by: Huang Shijie <sjhuang@iluvatar.ai>
> > ---
> >  drivers/dma/ti/edma.c | 8 ++------
> >  1 file changed, 2 insertions(+), 6 deletions(-)
> > 
> > diff --git a/drivers/dma/ti/edma.c b/drivers/dma/ti/edma.c
> > index ceabdea40ae0..28ba1e722c47 100644
> > --- a/drivers/dma/ti/edma.c
> > +++ b/drivers/dma/ti/edma.c
> > @@ -2388,18 +2388,17 @@ static int edma_probe(struct platform_device *pdev)
> >  	ecc->dma_slave.filter.mapcnt = info->slavecnt;
> >  	ecc->dma_slave.filter.fn = edma_filter_fn;
> >  
> > -	ret = dma_async_device_register(&ecc->dma_slave);
> > +	ret = dmaenginem_async_device_register(&ecc->dma_slave);
> >  	if (ret) {
> >  		dev_err(dev, "slave ddev registration failed (%d)\n", ret);
> >  		goto err_reg1;
> >  	}
> >  
> >  	if (ecc->dma_memcpy) {
> > -		ret = dma_async_device_register(ecc->dma_memcpy);
> > +		ret = dmaenginem_async_device_register(ecc->dma_memcpy);
> >  		if (ret) {
> >  			dev_err(dev, "memcpy ddev registration failed (%d)\n",
> >  				ret);
> > -			dma_async_device_unregister(&ecc->dma_slave);
> >  			goto err_reg1;
> >  		}
> >  	}
> > @@ -2439,9 +2438,6 @@ static int edma_remove(struct platform_device *pdev)
> >  
> >  	if (dev->of_node)
> >  		of_dma_controller_free(dev->of_node);
> > -	dma_async_device_unregister(&ecc->dma_slave);
> > -	if (ecc->dma_memcpy)
> > -		dma_async_device_unregister(ecc->dma_memcpy);
> 
> I'm afraid this is not safe either, we need to free the dummy_slot
> _after_ the dma device is unregistered.
> 
Thanks for pointing this.

I will drop this patch ...

Thanks
Huang Shijie