Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 09/46] dmaengine: cppi41: use
 dmaenginem_async_device_register to simplify the code
To:     Peter Ujfalusi <peter.ujfalusi@ti.com>, vkoul@kernel.org
Cc:     dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
        dave.jiang@intel.com, radhey.shyam.pandey@xilinx.com,
        appana.durga.rao@xilinx.com, jmkrzyszt@gmail.com,
        gomonovych@gmail.com, keescook@chromium.org,
        horms+renesas@verge.net.au, geert+renesas@glider.be,
        shawnguo@kernel.org, baoyou.xie@linaro.org,
        michal.simek@xilinx.com, baohua@kernel.org,
        ludovic.desroches@microchip.com, linus.walleij@linaro.org,
        david.brown@linaro.org
References: <20180803072016.21544-1-sjhuang@iluvatar.ai>
 <20180803072016.21544-10-sjhuang@iluvatar.ai>
 <43458794-d124-13df-c944-e473dc8ee1c2@ti.com>
From:   Huang Shijie <sjhuang@iluvatar.ai>
Message-ID: <b95f7ce3-b50f-ea62-dbfb-d25973230ec4@iluvatar.ai>
Date:   Fri, 3 Aug 2018 16:02:00 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <43458794-d124-13df-c944-e473dc8ee1c2@ti.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


=E5=9C=A8 2018=E5=B9=B408=E6=9C=8803=E6=97=A5 15:55, Peter Ujfalusi =E5=86=
=99=E9=81=93:
>
> On 2018-08-03 10:19, Huang Shijie wrote:
>> Use dmaenginem_async_device_register to simplify the code:
>>     remove dma_async_device_unregister
>>
>> Signed-off-by: Huang Shijie <sjhuang@iluvatar.ai>
>> ---
>>   drivers/dma/ti/cppi41.c | 7 ++-----
>>   1 file changed, 2 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/dma/ti/cppi41.c b/drivers/dma/ti/cppi41.c
>> index 1497da367710..d2998a19ed2e 100644
>> --- a/drivers/dma/ti/cppi41.c
>> +++ b/drivers/dma/ti/cppi41.c
>> @@ -1096,21 +1096,19 @@ static int cppi41_dma_probe(struct platform_de=
vice *pdev)
>>   		goto err_chans;
>>   	cdd->irq =3D irq;
>>  =20
>> -	ret =3D dma_async_device_register(&cdd->ddev);
>> +	ret =3D dmaenginem_async_device_register(&cdd->ddev);
>>   	if (ret)
>>   		goto err_chans;
>>  =20
>>   	ret =3D of_dma_controller_register(dev->of_node,
>>   			cppi41_dma_xlate, &cpp41_dma_info);
>>   	if (ret)
>> -		goto err_of;
>> +		goto err_chans;
>>  =20
>>   	pm_runtime_mark_last_busy(dev);
>>   	pm_runtime_put_autosuspend(dev);
>>  =20
>>   	return 0;
>> -err_of:
>> -	dma_async_device_unregister(&cdd->ddev);
>>   err_chans:
>>   	deinit_cppi41(dev, cdd);
>>   err_init_cppi:
>> @@ -1132,7 +1130,6 @@ static int cppi41_dma_remove(struct platform_dev=
ice *pdev)
>>   		dev_err(&pdev->dev, "%s could not pm_runtime_get: %i\n",
>>   			__func__, error);
>>   	of_dma_controller_free(pdev->dev.of_node);
>> -	dma_async_device_unregister(&cdd->ddev);
> If I read the code right then this is not safe.
> We would have deinitalized cppi41 driver which is not functional, but w=
e
> will still have the dma device registered and if a channel is requested
> we will have kernel crash.
>
> It falls in the same case as omap-dma, edma.
Thanks for pointing this, we can drop the patches for omap-dma, edma.

Huang Shijie