Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp218623imm; Fri, 3 Aug 2018 02:17:32 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeTTnRSBgSkIL6heRW3rZgi5adLjTTmVdK9Xo5A7/qqVrNRuNL5dZaABkUge3FAGz6PGlx+ X-Received: by 2002:a17:902:a24:: with SMTP id 33-v6mr2776178plo.88.1533287852091; Fri, 03 Aug 2018 02:17:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533287852; cv=none; d=google.com; s=arc-20160816; b=zJVyYSHV7CDuvlWEWpfoq1Dp6dOVkKDdsBGniYq5HUGRDUPGJV8cDHuLH9DUl/rDiE PqHOKAss8nLorV5dFqGxHnmgb6MjQxeFbL4N5FI2MUISPAEqTQ0deSSR+DqugI3fQHmT Vr/FhQZmMYqjeuCpWIOKGn6NqIKsKCGM4sd1jTyzCINbIOSBFJ5N7kFLdTwQvAyf7RhH OWr2Ty0NhGy7jKUkpAcP5jzNoEF0Ns8Y3VVjINahrxN5p5P3479oWWDRstx77PP0vqjU LAEhXlFu80piwJPfCU/+/wAN0PgXG3smTFD8FqpyiTSAWWufrD2gQO+V8k3QHZK83eJZ NQcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:content-id:mime-version :subject:cc:to:references:in-reply-to:from:organization :arc-authentication-results; bh=dFWgxBVCRdn7hq42iRlcZ03isLnQhyL9Qi4hnWHi6Zc=; b=cThadbWYdZPpzP/y+QzxxWUIUZ6t0siDEQFomh/l/RnYgp+1P7o/0b3/wt+pfbRal1 OCJ3FfmTd+un5QQasFAQHFPqPP/d7+y2zo3ipTxCUUZwNI9UV2F7nNMmE0VNsN9i/j0n 43SvLC0FdjpDFTLSdh+g0gqt4s5+f3+Kyxua87BVK0ZVcl3RUFe+IlywIxTok+SxBOby 0EgKd8dW9hL5rrgimscehuTmMXsGv67gTqbgrUonlo7+OHmm48V7QcYhwIguqRjICLat i+vcVrkbSE8fPlyEvuC4g9tRfAnzTU9q23k6KXuAtZDnhyXJ7ziheaYDkmlvJ9L1GGzW w+0w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 5-v6si4342677pgp.439.2018.08.03.02.16.53; Fri, 03 Aug 2018 02:17:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732449AbeHCLJz (ORCPT + 99 others); Fri, 3 Aug 2018 07:09:55 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:35904 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727866AbeHCLJz (ORCPT ); Fri, 3 Aug 2018 07:09:55 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 94BF18197012; Fri, 3 Aug 2018 09:14:30 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-78.rdu2.redhat.com [10.10.120.78]) by smtp.corp.redhat.com (Postfix) with ESMTP id 13EC47C3E; Fri, 3 Aug 2018 09:14:28 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20180724164936.37477-1-keescook@chromium.org> <20180724164936.37477-17-keescook@chromium.org> To: Kees Cook Cc: dhowells@redhat.com, Herbert Xu , Eric Biggers , "Gustavo A. R. Silva" , linux-crypto , Network Development , LKML , "David S. Miller" Subject: Re: [PATCH v6 16/18] rxrpc: Reuse SKCIPHER_REQUEST_ON_STACK buffer MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <9081.1533287668.1@warthog.procyon.org.uk> Date: Fri, 03 Aug 2018 10:14:28 +0100 Message-ID: <9082.1533287668@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Fri, 03 Aug 2018 09:14:30 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Fri, 03 Aug 2018 09:14:30 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'dhowells@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hmmm... I'm wondering if the skcipher request should be allocated on call initialisation and a pointer put in the rxrpc_call struct. It's only used serially for any particular call. For the moment, I'll pass your patch onto DaveM. David