Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 3 Aug 2018 12:26:23 +0200 (CEST)
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Alistair Strachan <astrachan@google.com>
cc:     linux-kernel@vger.kernel.org, Andy Lutomirski <luto@kernel.org>,
        Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        x86@kernel.org, kernel-team@android.com, joel@joelfernandes.com
Subject: Re: [PATCH] x86: vdso: Use $LD instead of $CC to link
In-Reply-To: <20180718224159.18236-1-astrachan@google.com>
Message-ID: <alpine.DEB.2.21.1808031223500.1745@nanos.tec.linutronix.de>
References: <20180718224159.18236-1-astrachan@google.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 18 Jul 2018, Alistair Strachan wrote:
>  export CPPFLAGS_vdso.lds += -P -C
>  
> -VDSO_LDFLAGS_vdso.lds = -m64 -Wl,-soname=linux-vdso.so.1 \
> -			-Wl,--no-undefined \
> -			-Wl,-z,max-page-size=4096 -Wl,-z,common-page-size=4096 \
> -			$(DISABLE_LTO)
> +VDSO_LDFLAGS_vdso.lds = -m elf_x86_64 -soname linux-vdso.so.1 --no-undefined \
> +			-z max-page-size=4096 -z common-page-size=4096

Aside of the fact that it does not apply to upstream, why is this dropping
the $(DISABLE_LTO) part?

The changelog is utterly silent about that.

Thanks,

	tglx