Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 3 Aug 2018 14:36:12 +0200
From:   Jean Delvare <jdelvare@suse.de>
To:     Parth Y Shah <sparth1292@gmail.com>
Cc:     arnd@arndb.de, gregkh@linuxfoundation.org, bhumirks@gmail.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] misc: eeprom: assignment outside the if statement
Message-ID: <20180803143612.121fba20@endymion>
In-Reply-To: <1533288043-19624-1-git-send-email-sparth1292@gmail.com>
References: <1533288043-19624-1-git-send-email-sparth1292@gmail.com>
Organization: SUSE Linux
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri,  3 Aug 2018 14:50:43 +0530, Parth Y Shah wrote:
> Assignment of any variable should be kept outside the if statement

Actually there are exceptions to that rule, but this isn't one of them.

> Signed-off-by: Parth Y Shah <sparth1292@gmail.com>
> ---
>  drivers/misc/eeprom/max6875.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/eeprom/max6875.c b/drivers/misc/eeprom/max6875.c
> index 0e32709..fc0cf9a 100644
> --- a/drivers/misc/eeprom/max6875.c
> +++ b/drivers/misc/eeprom/max6875.c
> @@ -148,7 +148,8 @@ static int max6875_probe(struct i2c_client *client,
>  	if (client->addr & 1)
>  		return -ENODEV;
>  
> -	if (!(data = kzalloc(sizeof(struct max6875_data), GFP_KERNEL)))
> +	data = kzalloc(sizeof(struct max6875_data), GFP_KERNEL);
> +	if (!data)
>  		return -ENOMEM;
>  
>  	/* A fake client is created on the odd address */

Reviewed-by: Jean Delvare <jdelvare@suse.de>

Thanks,
-- 
Jean Delvare
SUSE L3 Support