Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp523343imm; Fri, 3 Aug 2018 07:18:40 -0700 (PDT) X-Google-Smtp-Source: AAOMgpde5G37RPbKkAZ72NCo57TGaTRjrxF5pEGwjwNwnlx9ICmNDklLdIm49gP/jWIYVXzy3zp0 X-Received: by 2002:a63:1b17:: with SMTP id b23-v6mr4043783pgb.275.1533305920312; Fri, 03 Aug 2018 07:18:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533305920; cv=none; d=google.com; s=arc-20160816; b=RDQWLhYDMLWTdVLx9CMwkpmtIGmHmK9Z/zu04rrZaSjuTEFeQ1YEJViq+ql1sS3GOD fL2YQ86V2pegHKYq30fOrKvc6mhz5yOB15vge6YiKUO7MfsxZS25vQr+c3OFAWR0LZ0+ wEzRnYv6bCcUH3kZmjENTUHBEsN9VZ7KQi6BGxMJzkN21YsvbfERA5nnNUzEdKhJkzGU ahjrDcsmRu/csasQq74ypMJReBjo35eW+Ukntyp3SRFEr92S+2IGdv1TIV1jR6FKPqZ+ xVsBreaQODI32f1ijd4ftIY0WsSgEmKRpNrPvtA+XPxLGrhBcCNKntU7Wy0FmWmuHIZ/ BEfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature :arc-authentication-results; bh=Ge9uvA3anBX5tN9vDk+xvn4w5yjx0zE2gziwKzerChs=; b=qKo0TvS6SOMtpdYc64Dx3bQk9AJBm6VrOqU9qsyrCCK7+F/wki7EAAgmjb8lueC+u6 AdYDgxcknnBZA1uCvghrT8fQ099bicdmrcpXK3bQUwbJjVVW4W9NfGV3oRz/p4Q8InBx xTt8gmKxbNldWhmLEni8zfsL555bRw3QmMh2DLKTMRkuRaXCegIGIPQ7tU6xbzNv1ndK KFjz8+lX4JqTk7UriCxIeCPuhxPA+wW4sWMjBhNQvQ4ki+7j08Gg/olGsNYMc/U1EjWt OXm+fhVq8XqlSr0+i/RJGQdlrmJyph7wrW3oxRM11xnjZ7h29BtTqKilfZci1bc/3Ly7 NERw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=akMUqmVg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h189-v6si4721627pge.66.2018.08.03.07.18.25; Fri, 03 Aug 2018 07:18:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=akMUqmVg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732171AbeHCQOJ (ORCPT + 99 others); Fri, 3 Aug 2018 12:14:09 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:46311 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731948AbeHCQOJ (ORCPT ); Fri, 3 Aug 2018 12:14:09 -0400 Received: by mail-pg1-f195.google.com with SMTP id f14-v6so2391639pgv.13 for ; Fri, 03 Aug 2018 07:17:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ge9uvA3anBX5tN9vDk+xvn4w5yjx0zE2gziwKzerChs=; b=akMUqmVgmOqTVlSUKpaf6iycWQS/xtB9FIzJB6mNdFch3cOdV9Rtmgdcim3hiTj6yy dwP5EMdRLgk7kaPkVIXcwcLP3Oa5PlqnyuOEtaXhILUZGFYcTQy6W2Gf10l1aUrcsQmT u5gxKRwsYkGBWKR77Q3Rs+XijDyIo69IYsXAfKldBW48b7Y6zkotAtvnJqRDyJgBjjz/ ScoG7IDAWc4TR5yFJVmcNcrVTgUftrDQ8TbiKsjFTA/rsJTKqR0wl+uvvM1kw1ooU3Zb +TaTHCrRFuKCGoGmihI5YliojHG0Yxp3u5wNuPkiw/Pi/U6Et0IN0U2/0sJ7Op9iJFD3 WWTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ge9uvA3anBX5tN9vDk+xvn4w5yjx0zE2gziwKzerChs=; b=hFHBt4x+bbGnYI8PqcdRFwSE7if71EeeaNAYNn9h3VycWHhRzRW1fXu6VWq+pyidX+ xkeS5yaXxEhHxFhLftR0MKB5iFeqpCwwxEUlNAtJenaumz/erO2T0FinywmJ9/2tO0v+ g99d8VTAHzCSxedkmBKwdvszGj0pYrqZ9OqS8QLHSPMj5CqQotXpSx24ZSguuLhGo2d4 qUjUUXlKOy7kDxPTggm9FSHXmWw+Jk+/SyQcFUXSkGxvHgVoSkX81KnRcxy88OYFsVpd 5ssOs6l7mS0G6Kcf+hGYp0ODcgyuiwPj8YL74/B8DoE7SBuXU+mJCGPHEgnKW/4JaWrB ypHQ== X-Gm-Message-State: AOUpUlGY7EiM0HQXRyvLUya6Wln2X/E/oAZJ4Hlz7fdkmBpg5y3lKYp+ n2v3cDvsGgsidxM8uTv78Z4bGAsvMqAKaitZup0= X-Received: by 2002:a62:f40a:: with SMTP id r10-v6mr4739842pff.47.1533305855697; Fri, 03 Aug 2018 07:17:35 -0700 (PDT) MIME-Version: 1.0 References: <1533288043-19624-1-git-send-email-sparth1292@gmail.com> <20180803143612.121fba20@endymion> In-Reply-To: <20180803143612.121fba20@endymion> From: Parth Shah Date: Fri, 3 Aug 2018 19:47:18 +0530 Message-ID: Subject: Re: [PATCH] misc: eeprom: assignment outside the if statement To: jdelvare@suse.de Cc: Arnd Bergmann , Greg KH , Bhumika Goyal , linux-kernel@vger.kernel.org Content-Type: multipart/alternative; boundary="000000000000dc673b05728896ef" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --000000000000dc673b05728896ef Content-Type: text/plain; charset="UTF-8" Hello Jean, Thank you for your response. So, can we consider this patch? Regards, Parth Y Shah On Fri, Aug 3, 2018 at 6:06 PM Jean Delvare wrote: > On Fri, 3 Aug 2018 14:50:43 +0530, Parth Y Shah wrote: > > Assignment of any variable should be kept outside the if statement > > Actually there are exceptions to that rule, but this isn't one of them. > > > Signed-off-by: Parth Y Shah > > --- > > drivers/misc/eeprom/max6875.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/misc/eeprom/max6875.c > b/drivers/misc/eeprom/max6875.c > > index 0e32709..fc0cf9a 100644 > > --- a/drivers/misc/eeprom/max6875.c > > +++ b/drivers/misc/eeprom/max6875.c > > @@ -148,7 +148,8 @@ static int max6875_probe(struct i2c_client *client, > > if (client->addr & 1) > > return -ENODEV; > > > > - if (!(data = kzalloc(sizeof(struct max6875_data), GFP_KERNEL))) > > + data = kzalloc(sizeof(struct max6875_data), GFP_KERNEL); > > + if (!data) > > return -ENOMEM; > > > > /* A fake client is created on the odd address */ > > Reviewed-by: Jean Delvare > > Thanks, > -- > Jean Delvare > SUSE L3 Support > --000000000000dc673b05728896ef Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello Jean,

Thank you for= your response.

So, can we consider this patch?

Regards,
Parth Y Shah

On Fri, Aug 3, 2018 at 6:06 PM Jean Delvare <jdelvare@suse.de> wrote:
On Fri,=C2=A0 3 Aug 2018 14:50:43 +0530, Parth= Y Shah wrote:
> Assignment of any variable should be kept outside the if statement

Actually there are exceptions to that rule, but this isn't one of them.=

> Signed-off-by: Parth Y Shah <sparth1292@gmail.com>
> ---
>=C2=A0 drivers/misc/eeprom/max6875.c | 3 ++-
>=C2=A0 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/misc/eeprom/max6875.c b/drivers/misc/eeprom/max68= 75.c
> index 0e32709..fc0cf9a 100644
> --- a/drivers/misc/eeprom/max6875.c
> +++ b/drivers/misc/eeprom/max6875.c
> @@ -148,7 +148,8 @@ static int max6875_probe(struct i2c_client *client= ,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0if (client->addr & 1)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return -ENODEV;<= br> >=C2=A0
> -=C2=A0 =C2=A0 =C2=A0if (!(data =3D kzalloc(sizeof(struct max6875_data= ), GFP_KERNEL)))
> +=C2=A0 =C2=A0 =C2=A0data =3D kzalloc(sizeof(struct max6875_data), GFP= _KERNEL);
> +=C2=A0 =C2=A0 =C2=A0if (!data)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return -ENOMEM;<= br> >=C2=A0
>=C2=A0 =C2=A0 =C2=A0 =C2=A0/* A fake client is created on the odd addre= ss */

Reviewed-by: Jean Delvare <jdelvare@suse.de>

Thanks,
--
Jean Delvare
SUSE L3 Support
--000000000000dc673b05728896ef--