Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp565668imm; Fri, 3 Aug 2018 07:58:30 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdX6ziYUC4B6PcbCZk2syU3iN9/y4QZyKMMT8PBOm266lM396LKnLAtqCruPESjy4HG3Uaf X-Received: by 2002:a62:2e02:: with SMTP id u2-v6mr4929522pfu.134.1533308310339; Fri, 03 Aug 2018 07:58:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533308310; cv=none; d=google.com; s=arc-20160816; b=xAUn5jjTY/yk+PCmRlpME80MYy8S6DmJ43o5PQbG/sUZVpGfXwQQpnkK3pay12Mp64 Boii5avPxgjco9uZ0Khv11ugEwxbnVLAWOOejuhj/RDK225beeioXRxldsgTwGxYTi7Q o7k2leKrEm4VM+JAE4nhCTSwZm0sVvqOkdwkmTXh97cvRuoxXuzIqLDTlcQsNJRBcjyW /MttP+IjQdgvIDoPuflaiT6OYer52Fy8ZNuH8ug5Z4HI4LbL1b8HYJKfHFub65ACex+w Yj7TWaixeDXX72odZOORD7mqBrYfdC4F8ow9blxiCl8CAaYiz37IrQk73+hTPkVEKykT z2ZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=tzB6zb7B0a8UhF6McOY09+8NKT5aAiub0w3R3EZ4ODo=; b=zRWun6Vks5cjbZxrThx7MrtQHJ7SqmEewJUx86zPVHfJ7F2QKYeDRjf55chNkcysKY IcaZvAMNBcRKTmc1INit81JkfNQJWn2FktumEwQvZmknlnb1y7rxmWOzPJMWrKHz7tpv tD5vNddtBamb13oJArUkt4EWOjKa/PkjohYk4VUz2GiFQErc5fmxCIvjTy7MBaWgZCTY On2bqWjU7r5ue6zoJRO4KsCcpF0qS4vTsoE8UBTltgLwWRd7kGgZPBMqn+4IqdL4imHF zJ8JQyQdiS9uWbubSpNDsLIRpC7QEnIelRXbUGJDYfABs9zoKTAb53m7C3+mqzukH0bx hfgw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x68-v6si5377357pfc.239.2018.08.03.07.58.15; Fri, 03 Aug 2018 07:58:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732435AbeHCQxQ (ORCPT + 99 others); Fri, 3 Aug 2018 12:53:16 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:50012 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726115AbeHCQxP (ORCPT ); Fri, 3 Aug 2018 12:53:15 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4E3BA7DAC3; Fri, 3 Aug 2018 14:56:34 +0000 (UTC) Received: from redhat.com (ovpn-120-99.rdu2.redhat.com [10.10.120.99]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E75502026D65; Fri, 3 Aug 2018 14:56:33 +0000 (UTC) Date: Fri, 3 Aug 2018 09:56:32 -0500 From: Bill O'Donnell To: Thomas Bianchi Cc: linux-xfs@vger.kernel.org, "Darrick J. Wong" , linux-kernel@vger.kernel.org Subject: Re: [PATCH] xfs: substitute spaces with tabs Message-ID: <20180803145632.GB20657@redhat.com> References: <1533140611-23467-1-git-send-email-thomas.bianchi8@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1533140611-23467-1-git-send-email-thomas.bianchi8@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Fri, 03 Aug 2018 14:56:34 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Fri, 03 Aug 2018 14:56:34 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'billodo@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 01, 2018 at 06:22:25PM +0200, Thomas Bianchi wrote: > Inside xfs_attr_shortform_list removes spaces at the beginnig of the line > and replaces with tabs. > Issue found by checkpatch. > > ERROR: code indent should use tabs where possible > > Signed-off-by: Thomas Bianchi > --- looks fine. Reviewed-by: Bill O'Donnell > fs/xfs/xfs_attr_list.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/xfs_attr_list.c b/fs/xfs/xfs_attr_list.c > index f9ca801..a580340 100644 > --- a/fs/xfs/xfs_attr_list.c > +++ b/fs/xfs/xfs_attr_list.c > @@ -87,7 +87,7 @@ > */ > if (context->bufsize == 0 || > (XFS_ISRESET_CURSOR(cursor) && > - (dp->i_afp->if_bytes + sf->hdr.count * 16) < context->bufsize)) { > + (dp->i_afp->if_bytes + sf->hdr.count * 16) < context->bufsize)) { > for (i = 0, sfe = &sf->list[0]; i < sf->hdr.count; i++) { > context->put_listent(context, > sfe->flags, > -- > 1.8.3.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html