Subject: Re: [PATCH} fix defect with kobject memory leaks during del_gendisk
From: Steven Dake <sdake@mvista.com>
Reply-To: sdake@mvista.com
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org, mochel@osdl.org
In-Reply-To: <20030925072343.A4636@infradead.org>
References: <1064444526.13033.355.camel@persist.az.mvista.com>
	 <20030925072343.A4636@infradead.org>
Content-Type: text/plain
Organization: MontaVista Software, Inc.
Message-Id: <1064513050.4763.21.camel@persist.az.mvista.com>
Mime-Version: 1.0
Date: Thu, 25 Sep 2003 11:04:11 -0700
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 984
Lines: 25

On Wed, 2003-09-24 at 23:23, Christoph Hellwig wrote:
> On Wed, Sep 24, 2003 at 04:02:06PM -0700, Steven Dake wrote:
> > Unfortunately it appears that del_gendisk uses kobject_del to delete the
> > kobject.  If the kobject has a ktype release function, it is not called
> > in the kobject_del call path, but only in kobject_unregister.
> 
> That's intentional.  gendisks (like everything using kobjects) are
> reference counted and ->release is unly called after the last reference
> goes away, for gendisks that would be the last put_disk call.
> 
> Unless you miss the put_disk call (which md certainly has) there's
> no memeory leak.
> 
Thanks Christoph...

Looks like I'm barking up the wrong tree.  Time to go fix up md :)

-steve
> 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/